Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite SelectionModel #4533

Merged
merged 33 commits into from
Aug 26, 2020
Merged

Rewrite SelectionModel #4533

merged 33 commits into from
Aug 26, 2020

Commits on Aug 19, 2020

  1. Reverted SelectionModel.

    @grokys
    grokys committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    af90219 View commit details
    Browse the repository at this point in the history

  2. Fixed/skipped failing tests.

    @grokys
    grokys committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    95f9a98 View commit details
    Browse the repository at this point in the history

  3. Added skipped tests for #4496.

    @grokys
    grokys committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c2a1427 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. Reimplemented SelectionModel. 

    Handles only list selections, not nested selections.
    @grokys
    grokys committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    e62baca View commit details
    Browse the repository at this point in the history

  2. Added #nullable to SelectingItemsControl.

    @grokys
    grokys committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    a9f05f2 View commit details
    Browse the repository at this point in the history

  3. Started integrating new SelectionModel.

    @grokys
    grokys committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    a9b04a5 View commit details
    Browse the repository at this point in the history

  4. Refactored ItemSourceView. 

    - Inner list needs to be a non-generic `IList` because `IList<T>` is no covariant.
- Moved out of the Repeater directory as it's now general-purpose.
    @grokys
    grokys committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    c1b2e2d View commit details
    Browse the repository at this point in the history

  5. More integration of new SelectionModel.

    @grokys
    grokys committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    b2a473d View commit details
    Browse the repository at this point in the history

  6. Implemented SelectionMode.AlwaysSelected.

    @grokys
    grokys committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    1120820 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Use CollectionChangedEventManager in ItemsControl.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b4d615b View commit details
    Browse the repository at this point in the history

  2. Auto-select when items added.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    81b7b54 View commit details
    Browse the repository at this point in the history

  3. Copy listeners before notifying. 

    As raising the event can cause the listeners to change.
    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    562e6bb View commit details
    Browse the repository at this point in the history

  4. Reimplement commented-out code.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    04bcd16 View commit details
    Browse the repository at this point in the history

  5. Adjust a few expected test results.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    4c20313 View commit details
    Browse the repository at this point in the history

  6. Don't raise LostSelection when changing source.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b499321 View commit details
    Browse the repository at this point in the history

  7. Don't autoselect with no items.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    c677fb4 View commit details
    Browse the repository at this point in the history

  8. Add missing word.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    7d96713 View commit details
    Browse the repository at this point in the history

  9. Added back removed tests.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    0e7f24f View commit details
    Browse the repository at this point in the history

  10. Unskip tests we can handle now.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    55cbf4a View commit details
    Browse the repository at this point in the history

  11. Make restored tests pass.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    10b03b1 View commit details
    Browse the repository at this point in the history

  12. Use SelectionModel in samples.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    4e6ef0a View commit details
    Browse the repository at this point in the history

  13. Use SelectionModel in samples.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    fc2eb08 View commit details
    Browse the repository at this point in the history

  14. Use SelectedIndex in ComboBox.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    a40015c View commit details
    Browse the repository at this point in the history

  15. Refactor SelectedItemsSync.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    923fd36 View commit details
    Browse the repository at this point in the history

  16. Restore selection on reset.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    06390d4 View commit details
    Browse the repository at this point in the history

  17. Adjust expected output.

    @grokys
    grokys committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    bfbf58d View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Make remaining tests pass.

    @grokys
    grokys committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    9c83763 View commit details
    Browse the repository at this point in the history

  2. Fix working with collections of value types. 

    `IEnumerable<T>` is not covariant for value types, so we need to use the non-generic `IEnumerable` everywhere under the hood to ensure we can work with both value and reference types.
    @grokys
    grokys committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    e4f03fd View commit details
    Browse the repository at this point in the history

  3. Fix bad grammar.

    @grokys
    grokys committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    2f7cc3b View commit details
    Browse the repository at this point in the history

  4. Implement changing selection mode.

    @grokys
    grokys committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    a078974 View commit details
    Browse the repository at this point in the history

  5. Commit API compat baseline.

    @grokys
    grokys committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    aee3829 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into refactor/selectionmodel-rewrite

    @grokys
    grokys committed Aug 26, 2020
    Configuration menu
    Copy the full SHA
    c768385 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into refactor/selectionmodel-rewrite

    @danwalmsley
    danwalmsley authored Aug 26, 2020
    Configuration menu
    Copy the full SHA
    c1f5b8e View commit details
    Browse the repository at this point in the history