-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
Updated a few inaccurate docs
Also untangled __auto_splitter function
Fixed reset while in pause loop
Missing library and type stub Let all job matrix complete
Quick glance at the code. Edit: reread, I think I got it wrong first time around: I don't have the time to test over the weekend. So I'll check this out in details next week. |
I do have some concerns over the scaling. Coercing the ratio to be the same between the captured region and the split image is an intended feature to ensure that:
I also plan on implementing an independant X and Y scale, where the smallest between the region, the split image, or our max is used. So that it doesn't scale up needlessly. |
8fff87e
to
10a0d1d
Compare
2780a1e
to
72883d4
Compare
@zalgo3 Or I could do the changes myself and tag you as author if you'd like and that's easier for you. |
@Avasam Also, I have a few comments. I think cropping is a good idea, but if, for example, we want to refer to objects in the lower left and lower right of the screen, simply cropping may not reduce the amount of computation as much as we think. If we want to take advantage of the sparseness, it might be better to use a data structure such as |
Related to Toufool#157
In my environment, this implementation seemed to improve accuracy without losing FPS.
Note, however, that I only tested this by actually playing the game. Do you have another method to evaluate the accuracy? I just recently learned about this software and am sorry for my ignorance of the development process so far.