Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change sales response to data #103

Merged
merged 7 commits into from
Jun 11, 2020
Merged

Change sales response to data #103

merged 7 commits into from
Jun 11, 2020

Conversation

DechengMa
Copy link
Contributor

Closes #100

The Apple Store Connect API /v1/financeReports and /v1/salesReports will return binary a-gzip data which is not supported by the SDK yet.
This PR is to add support for downloading sales and trends reports.

Changes

  • downloadSalesAndTrendsReports, downloadFinanceReports APIEndpoint: T == Void -> Data
  • Tweak APIProvider for return raw data if T.self == Data.self

@DechengMa DechengMa requested a review from AvdLee as a code owner June 2, 2020 02:35
@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented Jun 2, 2020 •
edited
Loading

Messages
📖

View more details on Bitrise
📖 AppStoreConnect-Swift-SDK: Executed 157 tests, with 0 failures (0 unexpected) in 0.906 (1.366) seconds

AppStoreConnect_Swift_SDK.framework: Coverage: 82.52

File Coverage
DownloadFinanceReports.swift 100.0% ✅
APIProvider.swift 85.83% ✅
DownloadSalesAndTrendsReports.swift 100.0% ✅

Generated by 🚫 Danger Swift against b35f550

AvdLee
AvdLee requested changes Jun 4, 2020
View reviewed changes
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Would you mind writing a test for this part?

Sources/APIProvider.swift Outdated Show resolved Hide resolved
@DechengMa DechengMa requested a review from AvdLee June 9, 2020 00:20
@AvdLee
Copy link
Owner

AvdLee commented Jun 11, 2020

Thanks for adding the test! 🎉

@AvdLee AvdLee merged commit 2abaffe into AvdLee:master Jun 11, 2020
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.1.2 🚀

Generated by GitBuddy

@SwiftLeeBot SwiftLeeBot mentioned this pull request Jun 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnarr kinnarr kinnarr left review comments

@AvdLee AvdLee AvdLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return Response instead of Void for "Sales and Finance Reports" endpoints
4 participants
@DechengMa @SwiftLeeBot @AvdLee @kinnarr