Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing cases for ProfileState #119

Merged
merged 5 commits into from
Sep 30, 2020
Merged

Add missing cases for ProfileState #119

merged 5 commits into from
Sep 30, 2020

Conversation

DechengMa
Copy link
Contributor

Changes

Currently list Profile request will produce

Cannot initialize ProfileState from invalid String value EXPIRED

This PR is to add the missing cases EXPIRED for ProfileState

DechengMa and others added 4 commits June 12, 2020 09:48
@DechengMa
Merge pull request #4 from AvdLee/master
65d95d0 
Add additional certficate types (AvdLee#105)
@DechengMa
Merge pull request #6 from AvdLee/master
b00cde9 
Add nextLimit property to PagedDocumentLinks and respect it in Endpoi…
@DechengMa
add expired case for ProfileState
4f08c71
@orj
Merge pull request #7 from ittybittyapps/profile-state-fix
c7ab261 
Add expired case for ProfileState
@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented Sep 30, 2020 •
edited
Loading

Warnings
⚠️

Tests/APIProviderTests.swift#L126 - cannot match several associated values at once, implicitly tupling the associated values and trying to match that instead
Messages
📖

View more details on Bitrise
📖 AppStoreConnect-Swift-SDK: Executed 157 tests, with 0 failures (0 unexpected) in 0.670 (1.237) seconds

Generated by 🚫 Danger Swift against 8ddedc1

AvdLee
AvdLee approved these changes Sep 30, 2020
View reviewed changes
Copy link
Owner

@AvdLee AvdLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is very welcome!

@AvdLee AvdLee merged commit 065f8e5 into AvdLee:master Sep 30, 2020
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.2.0 🚀

Generated by GitBuddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvdLee AvdLee AvdLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DechengMa @SwiftLeeBot @AvdLee @orj