Adding download on RequestExecutor #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppStoreConnect-Swift-SDKTests.xctest: Coverage: 99.56
AppStoreConnect_Swift_SDK.framework: Coverage: 80.79
Generated by 🚫 Danger Swift against 0fba0da |
AvdLee
requested changes
Mar 5, 2021
Sources/APIProvider.swift
Outdated
Comment on lines
160
to
161
|
|
||
|
|
Sources/DefaultRequestExecutor.swift
Outdated
Comment on lines
56
to
57
|
|
||
|
|
|
@AvdLee I remove the extras lines add some tests and put a time zone on the testDateDecoding because it was failing on my computer has I am on an other time zone. |
AvdLee
approved these changes
Mar 10, 2021
| func testDateDecoding() throws { | ||
| let decoder = APIProvider.jsonDecoder | ||
| let outputFormatter = DateFormatter() | ||
| outputFormatter.dateFormat = "E, d MMM yyyy HH:mm:ss Z" | ||
| outputFormatter.locale = Locale(identifier: "en_US_POSIX") | ||
|
|
||
| outputFormatter.timeZone = TimeZone(identifier: "GMT") |
|
Congratulations! 🎉 This was released as part of Release 1.4.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I think the download of the reports should be through downloadTask instead of a dataTask so I recreate a new method to user downloadTask instead of dataTask. I was not able to run the tests. Can you helped me run it?