Fix Read Beta Group Information and update to match Apple's docs #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppStoreConnect-Swift-SDKTests.xctest: Coverage: 99.66
AppStoreConnect_Swift_SDK.framework: Coverage: 81.33
Generated by 🚫 Danger Swift against d2320a8 |
AvdLee
requested changes
May 10, 2021
There was a problem hiding this comment.
Thanks for your contribution! I don't think we need your gitignore and Gemfile changes, they have never been an issue before. I'm also surprised that GEM is using the vendor folder. This must be some personal configuration maybe?
Either way, if you can remove those changes, that would be great 🙂
scottlemke
force-pushed
the
feature/fix-betagroupinfo
branch
from
8ddb13d
to
79f05f1
Compare
|
@AvdLee Apologies for that. I didn't realize that it would pick up my local settings for the bundle install. I dropped the gitignore and gemfile changes. |
scottlemke
force-pushed
the
feature/fix-betagroupinfo
branch
from
b6675de
to
d2320a8
Compare
AvdLee
approved these changes
May 11, 2021
|
Congratulations! 🎉 This was released as part of Release 1.5.0 🚀 Generated by GitBuddy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
Read Beta Group InformationAPI was broken, so I fixed the broken fields and updated all parameters to match Apple's documentation. Tests were added for each individual field.Changes in this PR
ReadBetaGroupInformationwas updated so it matches the API specsReadBetaGroupInformationTestswere updated with more granular tests for future expandability.gitignorewas updated to ignore thevendordirectoryGemfile.lockfile was checked inQuestions
There were a couple changes I made at the end of my commits when I was following the instructions for Development. I updated the
.gitignorefile so that thevendordirectory that is created by bundler no longer appears as a change. I also checked in the Gemfile.lock file so versions are pinned for the bundle install. If you would like me to remove either of these changes, please let me know.