Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift 5.1 support #49

Merged
merged 3 commits into from
Dec 13, 2019
Merged

Swift 5.1 support #49

merged 3 commits into from
Dec 13, 2019

Conversation

ruipfcosta
Copy link
Collaborator

@ruipfcosta ruipfcosta commented Dec 7, 2019 •
edited
Loading

This PR updates the package description to use swift-tools-version 5.1 and set the minimum version of both iOS and MacOS, in line with the deployment targets defined in https://github.com/AvdLee/appstoreconnect-swift-sdk/blob/master/AppStoreConnect-Swift-SDK.podspec.
This fixes the compiler errors when trying to build with Swift 5.1.

@SwiftLeeBot
Copy link
Collaborator

SwiftLeeBot commented Dec 7, 2019 •
edited
Loading

Danger has errored

[!] Invalid Dangerfile file: uninitialized constant Danger::Dangerfile::OtherError

 #  from /Users/travis/build/AvdLee/appstoreconnect-swift-sdk/fastlane/../Submodules/WeTransfer-iOS-CI/Danger/Dangerfile:49
 #  -------------------------------------------
 #    end
 >  rescue OtherError
 #    fail('Code coverage creation failed')
 #  -------------------------------------------

Generated by 🚫 Danger

@ruipfcosta ruipfcosta changed the title Update package description Swift 5.1 support Dec 7, 2019
AvdLee
AvdLee reviewed Dec 13, 2019
View reviewed changes
.travis.yml
@@ -1,5 +1,5 @@
language: objective-c
osx_image: xcode10.1
osx_image: xcode11.1
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should update CI completely to support the new Xcode. Thanks for taking care of this though!

@AvdLee AvdLee merged commit 6628399 into AvdLee:master Dec 13, 2019
@ruipfcosta ruipfcosta deleted the set-minimum-platform-versions branch December 13, 2019 10:16
@SwiftLeeBot
Copy link
Collaborator

Congratulations! 🎉 This was released as part of Release 1.0.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvdLee AvdLee AvdLee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruipfcosta @SwiftLeeBot @AvdLee