Implemented endpoints for modifying and removing Bundle IDs #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruipfcosta
force-pushed
the
bundle-id-endpoints
branch
from
5864982
to
86fc68f
Compare
ghost
reviewed
Dec 31, 2019
| // Created by Rui Costa on 30/12/2019. | ||
| // | ||
|
|
||
|
|
There was a problem hiding this comment.
Limit vertical whitespace to a single empty line. Currently 2.vertical_whitespace BundleIdUpdateRequest.swift:8 |
ghost
reviewed
Dec 31, 2019
| public struct BundleIdUpdateRequest: Encodable { | ||
|
|
||
| /// The resource data. | ||
| public let data: Data |
There was a problem hiding this comment.
An ‘instance_property’ should not be placed amongst the type content(s) ‘subtype’.type_contents_order BundleIdUpdateRequest.swift:15 |
ghost
reviewed
Dec 31, 2019
| public let name: String | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Files should have a single trailing newline.trailing_newline BundleIdUpdateRequest.swift:31 |
|
I realised these endpoints have already been implemented in #57. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the endpoints to modify and remove Bundle IDs. I will add the remaining endpoints in a separate PR (still need to get my head around the implementation 😅).