-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the parsing of Profile responses #95
Conversation
- Adds a test for this
To make it easier to debug decoding failures
The custom date decoding is useful for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how you've tested this through! There might come back a few warnings from CI. Would be great if you could fix those 🙂
AppStoreConnect_Swift_SDK.framework: Coverage: 82.5
Generated by 🚫 Danger Swift against 3604392 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Congratulations! 🎉 This was released as part of Release 1.1.0 🚀 Generated by GitBuddy |
There are a number of errors in the parsing of Profiles.
This PR includes the following changes:
Changes of Note
ProfilesResponse
correctly parsesMisc Changes
This is an API breaking change as I changed the public types, in particular
APIProvider.Error
.