Fixed bugs relate to prevent copying to itself. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2014 21:31
Add more testcases
| rimraf(src_out, function(e) { | ||
| fs.mkdirSync(src_out); | ||
| rimraf(double_src_before_out, function() { | ||
| mkdirp.sync(double_src_before_out); |
There was a problem hiding this comment.
The double_src_before_out is similar to C:\source\C:\source_out. So it will block the whole testcase.
double_src_middle_out causes the same issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to fix the issue #60, If I missed something , please let me know.
This PR refactoring the
startsWithfunction and try to handle more situations. I add more testcases to test the different situations. * Some testcases can't used in Windows* :srctosrc/outsrctosrcsrcsrctosrc_outsrctosrc-symlinksrc/a tosrc/asrctosrc/src_outsrctosrc_out/srcAnd I add mkdirp to devDependencies to create the directory easily.