Logout option full reset #1107
Draft
Logout option full reset #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dfsm
commented
Aug 7, 2021
dfsm
commented
- Log out option will now only delete the cookie and present the login screen
- New option added "Full reset". This performs the actions Log Out did previously
- Removed all traces of the MiniOnePassword package. This is no longer required as iOS supports 1password for login fields
- Updated Login.storyboard to set fields as Username and Password. This allows iOS to present password manager options
- Log out option will now only delete the cookie and present the login screen - New option added "Full reset". This performs the actions Log Out did previously - Removed all traces of the MiniOnePassword package. This is no longer required as iOS supports 1password for login fields - Updated Login.storyboard to set fields as Username and Password. This allows iOS to present password manager options
…reviously Log Out). This commit sorts one that was being caused by applicationWillResignActive and applicationDidBecomeActive and the SmilieKeyboardSetIsAwfulAppActive commands. Changed these to applicationWillEnterForeground and applicationDidEnterBackground, which seems to sort it. Hopefully this change is OK There is still one crash present due to coredata being deleted but still referenced in memory (I think?)
nolanw
reviewed
Aug 14, 2021
There was a problem hiding this comment.
This makes sense to me. I think the ideal way to handle this is app-modal "your session has expired, please log in again" screen with a "full reset" option from there, and then the manual "Log out" button can go back to being the full reset, because I assume almost nobody will manually log out. But I like this as a quicker solution!
The iOS password fill-in thing, do you know what iOS version that requires? We might want to keep MiniOnePassword for older versions.
| @@ -121,13 +124,13 @@ final class AppDelegate: UIResponder, UIApplicationDelegate { | |||
| return true | |||
| } | |||
|
|
|||
| func applicationWillResignActive(_ application: UIApplication) { | |||
| func applicationDidEnterBackground(_ application: UIApplication) { | |||
There was a problem hiding this comment.
What's the reasoning here and with DidBecomeActive/WillEnterForeground below? (Not saying it's wrong!)
| annotation: options[UIApplication.OpenURLOptionsKey.annotation] as Any | ||
| ) | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.