Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(TitleBar) : Add Left Title Property to TitleBar #1187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor(TitleBar) : Add Left Title Property to TitleBar #1187

wants to merge 1 commit into from

Conversation

Nolann-epi
Copy link

@MartinWeb MartinWeb added this to the V3.0.0 milestone May 13, 2024
@MartinWeb MartinWeb added the Type: Enhancement New feature or request label May 13, 2024
GuillaumeKESTEMAN
GuillaumeKESTEMAN reviewed May 15, 2024
View reviewed changes
Copy link
Contributor

@GuillaumeKESTEMAN GuillaumeKESTEMAN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise, it's ok for me.
But for design on the storybook there are things that bother me :

Were these changes planned?

@MartinWeb MartinWeb added the REPLICATE IN NEW DESIGN SYSTEM Don't forget to replicate in new design system project label Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeKESTEMAN GuillaumeKESTEMAN GuillaumeKESTEMAN left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
REPLICATE IN NEW DESIGN SYSTEM Don't forget to replicate in new design system project Type: Enhancement New feature or request
Projects
None yet
Milestone
V3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Nolann-epi @GuillaumeKESTEMAN @MartinWeb