Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for main function in src/setup-renpy.ts #17

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

Ayowel
Copy link
Owner

@Ayowel Ayowel commented Mar 1, 2023

Add tests to setup-renpy.ts for coverage. The aim is only to provide very basic unit tests on the execution logic, not to provide integration tests at main's level.
This also revealed a missing update in main to support mac runners

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 90.90% and project coverage change: +12.16 🎉

Comparison is base (a58f2bd) 72.23% compared to head (7201abb) 84.40%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##           develop      #17       +/-   ##
============================================
+ Coverage    72.23%   84.40%   +12.16%     
============================================
  Files            8        8               
  Lines          317      327       +10     
  Branches        44       45        +1     
============================================
+ Hits           229      276       +47     
+ Misses          50       12       -38     
- Partials        38       39        +1     
Flag Coverage Δ
macos-latest ?
ubuntu-latest 84.40% <90.90%> (+12.16%) ⬆️
windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/setup-renpy.ts 84.00% <83.33%> (+84.00%) ⬆️
src/adapter/parameters.ts 83.63% <100.00%> (+0.61%) ⬆️
src/controller/executor.ts 88.09% <100.00%> (+0.59%) ⬆️
src/model/parameters.ts 77.77% <100.00%> (+2.77%) ⬆️
src/adapter/system.ts 85.71% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ayowel Ayowel merged commit dd76b4e into develop Mar 2, 2023
@Ayowel Ayowel deleted the feature/main-tests branch March 2, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants