Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce default rapt keystore config values #22

Merged
merged 4 commits into from
Sep 24, 2023

Conversation

Ayowel
Copy link
Owner

@Ayowel Ayowel commented Sep 20, 2023

Since Ren'Py 8.1.0, Ren'py does not provide default project config, hence the enforcing of default values if none is set.

Additionally, we want to check for the file's content as Ren'Py rebuilds those config files if the some options are not set in the android config.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2023

Codecov Report

Patch coverage: 57.89% and project coverage change: -1.33% ⚠️

Comparison is base (65b3a8a) 84.06% compared to head (1a44501) 82.74%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   84.06%   82.74%   -1.33%     
==========================================
  Files          12       12              
  Lines         408      423      +15     
  Branches       59       64       +5     
==========================================
+ Hits          343      350       +7     
- Misses         13       17       +4     
- Partials       52       56       +4     
Flag Coverage Δ
macos-latest 82.74% <57.89%> (-1.33%) ⬇️
ubuntu-latest 82.74% <57.89%> (-1.33%) ⬇️
windows-latest 82.74% <57.89%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/adapter/system.ts 85.71% <ø> (ø)
src/setup-renpy.ts 83.07% <37.50%> (-6.40%) ⬇️
src/controller/installer.ts 79.31% <72.72%> (-3.05%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ayowel Ayowel force-pushed the fix/renpy-8.1.X-android-build branch from f348d80 to 6e69af8 Compare September 22, 2023 18:06
@Ayowel Ayowel force-pushed the fix/renpy-8.1.X-android-build branch from 9c73e88 to 1a44501 Compare September 24, 2023 08:00
@Ayowel Ayowel merged commit 412fc90 into master Sep 24, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants