Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customised path for Dex not working #128

Closed
stanleyz opened this issue Jul 9, 2024 · 1 comment · Fixed by #129
Closed

Customised path for Dex not working #128

stanleyz opened this issue Jul 9, 2024 · 1 comment · Fixed by #129

Comments

@stanleyz
Copy link
Contributor

stanleyz commented Jul 9, 2024

There is a parameter in values.yaml to configure the path for Dex, namely .Values.ingress.dex.path, but /dex is refered in some places directly, for example in the below line

terrakube-helm-chart/charts/terrakube/templates/secrets-registry.yaml

Line 17 in 57db6ad

AppIssuerUri: '{{- if .Values.ingress.useTls }}https{{else}}http{{ end }}://{{ .Values.ingress.api.domain }}/dex'

@alfespa17
Copy link
Member

Hello @stanleyz, you are right I think that part can be changed and take the value from the dex config path

stanleyz added a commit to stanleyz/terrakube-helm-chart that referenced this issue Jul 10, 2024
@stanleyz
fix: AzBuilder#128 make sure the customised Dex issuer URL is used
e9abba8 
Problem:

The /dex was hard-coded in the affect file which stop Terrakube Registry
to be working with customized Dex path

This change address this by using the value of `issuer` from Dex
configuration section.
@stanleyz stanleyz mentioned this issue Jul 10, 2024
Merged
stanleyz added a commit to stanleyz/terrakube-helm-chart that referenced this issue Jul 10, 2024
@stanleyz
fix: AzBuilder#128 make sure the customised Dex issuer URL is used
5612b48 
Problem:

The /dex was hard-coded in the affect file which stop Terrakube Registry
to be working with customized Dex path

This change address this by using the value of `issuer` from Dex
configuration section.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #128 make sure the customised Dex issuer URL is used stanleyz/terrakube-helm-chart
2 participants
@stanleyz @alfespa17