Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing registry field #39

Merged
merged 3 commits into from
Nov 24, 2022
Merged

Fix missing registry field #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fd09ff
Fix missing property
alfespa17 Nov 24, 2022
5a5bf25
Fix merge
alfespa17 Nov 24, 2022
c3b0dd8
Fix merge
alfespa17 Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ Once you have completed the above steps you can complete the file values.yaml to
| registry.version | Yes | |
| registry.replicaCount | Yes | |
| registry.serviceType | Yes | ClusterIP/NodePort/LoadBalancer/ExternalName |
| registry.properties.DexClientId | Yes | Dex Client Id for authentication |
| registry.env | No | |
| registry.volumes | No | |
| registry.volumeMounts | No | |
Expand Down
4 changes: 3 additions & 1 deletion templates/secrets-registry.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ stringData:
InternalSecret: '{{ .Values.security.internalSecret | b64enc }}'
TerrakubeEnableSecurity: 'true'
TerrakubeUiURL: 'https://{{ .Values.ingress.ui.domain }}'

AppClientId: '{{ .Values.registry.properties.DexClientId }}'
AppIssuerUri: 'https://{{ .Values.ingress.api.domain }}/dex'

{{- if and (.Values.storage.azure).storageAccountName (.Values.storage.azure).storageAccountAccessKey }}
#Azure Storage
RegistryStorageType: 'AzureStorageImpl'
Expand Down
10 changes: 10 additions & 0 deletions values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,16 @@
"type": "object"
}
}
},
"properties": {
"type": "object",
"required": ["DexClientId"],
"properties": {
"DexClientId": {
"description": "Dex client id for the terraform login",
"type": "string"
}
}
}
}
},
Expand Down