Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Euler redemption bridge #323

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Euler redemption bridge #323

wants to merge 4 commits into from

Conversation

LHerskind
Copy link
Collaborator

Description

Adds a bridge to perform euler redemptions using the ERC4626 migrator at https://github.com/LHerskind/euler-4626-redemption. The bridge is stateless.

The gas cost is pretty horrible, as there are multiple swaps to give back users their "expected" assets, but as they can be aggregated heavily, should be ok.

Needs a deployment script + being added to the frontend.

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • There are no unexpected formatting changes, or superfluous debug logs.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewers next convenience.
  • NatSpec documentation of all the non-test functions is present and is complete.
  • Continuous integration (CI) passes.
  • Command forge coverage --match-contract MyContract returns 100% line coverage.
  • All the possible reverts are tested.

@LHerskind LHerskind added stateless For bridges that hold no state new bridge Bridge to previously unsupported protocol labels Apr 12, 2023
benesjan
benesjan approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks very nice and it's tested well enough. Good job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benesjan benesjan benesjan approved these changes

@rahul-kothari rahul-kothari Awaiting requested review from rahul-kothari

@Maddiaa0 Maddiaa0 Awaiting requested review from Maddiaa0

Assignees
No one assigned
Labels
new bridge Bridge to previously unsupported protocol stateless For bridges that hold no state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LHerskind @benesjan