Skip to content

Commit

Permalink
fix(avm): update codegen
Browse files Browse the repository at this point in the history
  • Loading branch information
IlyasRidhuan committed Jun 25, 2024
1 parent c661fde commit 84a0da5
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 6 deletions.
2 changes: 2 additions & 0 deletions barretenberg/cpp/src/barretenberg/vm/generated/avm_prover.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ class AvmProver {
using Flavor = AvmFlavor;
using FF = Flavor::FF;
using PCS = Flavor::PCS;
using Curve = Flavor::Curve;
using ZeroMorph = ZeroMorphProver_<Curve>;
using PCSCommitmentKey = Flavor::CommitmentKey;
using ProvingKey = Flavor::ProvingKey;
using Polynomial = Flavor::Polynomial;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ bool AvmVerifier::verify_proof(const HonkProof& proof, const std::vector<std::ve
using FF = Flavor::FF;
using Commitment = Flavor::Commitment;
// using PCS = Flavor::PCS;
// using ZeroMorph = ZeroMorphVerifier_<PCS>;
// using Curve = Flavor::Curve;
// using ZeroMorph = ZeroMorphVerifier_<Curve>;
using VerifierCommitments = Flavor::VerifierCommitments;
using CommitmentLabels = Flavor::CommitmentLabels;

Expand Down Expand Up @@ -739,13 +740,15 @@ bool AvmVerifier::verify_proof(const HonkProof& proof, const std::vector<std::ve
// Execute ZeroMorph rounds. See https://hackmd.io/dlf9xEwhTQyE3hiGbq4FsA?view for a complete description of the
// unrolled protocol.
// NOTE: temporarily disabled - facing integration issues
// auto pairing_points = ZeroMorph::verify(commitments.get_unshifted(),
// auto opening_claim = ZeroMorph::verify(commitments.get_unshifted(),
// commitments.get_to_be_shifted(),
// claimed_evaluations.get_unshifted(),
// claimed_evaluations.get_shifted(),
// multivariate_challenge,
// pcs_verification_key->get_g1_identity(),
// transcript);

// auto pairing_points = PCS::reduce_verify(opening_claim, transcript);
// auto verified = pcs_verification_key->pairing_check(pairing_points[0], pairing_points[1]);
// return sumcheck_verified.value() && verified;
return sumcheck_verified.value();
Expand Down
4 changes: 2 additions & 2 deletions bb-pilcom/bb-pil-backend/src/prover_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ impl ProverBuilder for BBFiles {
using Flavor = {name}Flavor;
using FF = Flavor::FF;
using PCS = Flavor::PCS;
using Curve = Flavor::Curve;
using ZeroMorph = ZeroMorphProver_<Curve>;
using PCSCommitmentKey = Flavor::CommitmentKey;
using ProvingKey = Flavor::ProvingKey;
using Polynomial = Flavor::Polynomial;
Expand Down Expand Up @@ -64,8 +66,6 @@ impl ProverBuilder for BBFiles {
std::shared_ptr<PCSCommitmentKey> commitment_key;
using ZeroMorph = ZeroMorphProver_<PCS>;
private:
HonkProof proof;
}};
Expand Down
7 changes: 5 additions & 2 deletions bb-pilcom/bb-pil-backend/src/verifier_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,8 @@ impl VerifierBuilder for BBFiles {
using FF = Flavor::FF;
using Commitment = Flavor::Commitment;
// using PCS = Flavor::PCS;
// using ZeroMorph = ZeroMorphVerifier_<PCS>;
// using Curve = Flavor::Curve;
// using ZeroMorph = ZeroMorphVerifier_<Curve>;
using VerifierCommitments = Flavor::VerifierCommitments;
using CommitmentLabels = Flavor::CommitmentLabels;
Expand Down Expand Up @@ -182,13 +183,15 @@ impl VerifierBuilder for BBFiles {
// Execute ZeroMorph rounds. See https://hackmd.io/dlf9xEwhTQyE3hiGbq4FsA?view for a complete description of the
// unrolled protocol.
// NOTE: temporarily disabled - facing integration issues
// auto pairing_points = ZeroMorph::verify(commitments.get_unshifted(),
// auto opening_claim = ZeroMorph::verify(commitments.get_unshifted(),
// commitments.get_to_be_shifted(),
// claimed_evaluations.get_unshifted(),
// claimed_evaluations.get_shifted(),
// multivariate_challenge,
// pcs_verification_key->get_g1_identity(),
// transcript);
// auto pairing_points = PCS::reduce_verify(opening_claim, transcript);
// auto verified = pcs_verification_key->pairing_check(pairing_points[0], pairing_points[1]);
// return sumcheck_verified.value() && verified;
return sumcheck_verified.value();
Expand Down

0 comments on commit 84a0da5

Please sign in to comment.