Skip to content

Commit

Permalink
fix: Memory init with no other ops gate counting (#7427)
Browse files Browse the repository at this point in the history
  • Loading branch information
sirasistant authored Jul 10, 2024
1 parent ec39e4e commit e7177ba
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,8 @@ AcirFormat circuit_serde_to_acir_format(Program::Circuit const& circuit, bool ho
} else if constexpr (std::is_same_v<T, Program::Opcode::MemoryInit>) {
auto block = handle_memory_init(arg);
uint32_t block_id = arg.block_id.value;
block_id_to_block_constraint[block_id] = std::make_pair(block, std::vector<size_t>());
std::vector<size_t> opcode_indices = { i };
block_id_to_block_constraint[block_id] = std::make_pair(block, opcode_indices);
} else if constexpr (std::is_same_v<T, Program::Opcode::MemoryOp>) {
auto block = block_id_to_block_constraint.find(arg.block_id.value);
if (block == block_id_to_block_constraint.end()) {
Expand Down

1 comment on commit e7177ba

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: e7177ba Previous: 62177fe Ratio
nativeconstruct_proof_ultrahonk_power_of_2/20 5193.16182 ms/iter 4737.592191000004 ms/iter 1.10

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.