Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Testing with Typescript page #2913

Closed
Tracked by #2658
benesjan opened this issue Oct 18, 2023 · 1 comment · Fixed by #3733
Closed
Tracked by #2658

Improve Testing with Typescript page #2913

benesjan opened this issue Oct 18, 2023 · 1 comment · Fixed by #3733
Assignees
Labels
A-documentation Area: relates to documentation

Comments

@benesjan
Copy link
Contributor

benesjan commented Oct 18, 2023

Improve "Testing with Typescript" page to document functionality from #2911. Document debug_log oracles and dump there any other relevant knowledge you have.

Document what to do when a note doesn't "appear" when emitting and fetching it etc. --> a lot of grantees had issues with this.

@rahul-kothari
Copy link
Contributor

https://github.com/AztecProtocol/aztec-packages/pull/3221/files

@critesjosh Jan added debugInfo to tx receipts that could be added!

critesjosh added a commit that referenced this issue Dec 19, 2023
- Update the dapp tutorial testing page to not reference the npm setup
- Update the testing tutorials page to mention the debug options on
waiting for a transaction

closes #2913 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Cat McGee <[email protected]>
Co-authored-by: Jan Beneš <[email protected]>
Maddiaa0 pushed a commit that referenced this issue Jan 8, 2024
- Update the dapp tutorial testing page to not reference the npm setup
- Update the testing tutorials page to mention the debug options on
waiting for a transaction

closes #2913 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Cat McGee <[email protected]>
Co-authored-by: Jan Beneš <[email protected]>
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
- Update the dapp tutorial testing page to not reference the npm setup
- Update the testing tutorials page to mention the debug options on
waiting for a transaction

closes AztecProtocol#2913 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Cat McGee <[email protected]>
Co-authored-by: Jan Beneš <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-documentation Area: relates to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants