Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

public-vm(simulator): Journal should keep track of reverted state #3998

Closed
Tracked by #3313
Maddiaa0 opened this issue Jan 12, 2024 · 0 comments · Fixed by #4349
Closed
Tracked by #3313

public-vm(simulator): Journal should keep track of reverted state #3998

Maddiaa0 opened this issue Jan 12, 2024 · 0 comments · Fixed by #4349
Assignees
Labels
C-avm Component: AVM related tickets (aka public VM)

Comments

@Maddiaa0
Copy link
Member

Maddiaa0 commented Jan 12, 2024

Overview

When a call reverts in the journal, its current behaviour drops it essentially making it such that the state updates never occured.

This is perfectly fine for a native implementation; however we still need to prove memory accesses as they occur, as we later need to prove that they took place in the storage read validation circuit ( in the vm or later in the vm).

The journal should have another section, or sub journal. That keeps track of reverted state seperately to the state we want to commit to the world state at the end of block execution.

Depends on

Links

@dbanks12 dbanks12 added the C-avm Component: AVM related tickets (aka public VM) label Jan 16, 2024
@dbanks12 dbanks12 added this to the AVM Simulator (partial) milestone Jan 30, 2024
@dbanks12 dbanks12 changed the title public-vm(ts): Journal should keep track of reverted state public-vm(simulator): Journal should keep track of reverted state Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-avm Component: AVM related tickets (aka public VM)
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants