refactor(aztec-nr): unify contexts behind interfaces

[fcarreiro]

• Unified common parts of {Public,Private,AVM}Context behind ContextInterface
• Created (temporary) PublicContextInterface to unify Public/AVM

[fcarreiro]

• refactor(aztec-nr)!: move nullifier testing inside contexts #5336
• refactor(aztec-nr): unify contexts behind interfaces #5294 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite

[spalladino]

When should we use the _raw versions as opposed to the non-raw ones?

[fcarreiro]

It's unclear right now. We'll probably change the public interface once we are done and the current public is gone. For the moment, I kept the inaccesible methods (like these) outside of the PublicContextInterface.

[AztecBot]

Benchmark results

Metrics with a significant change:

• tx_sequencer_processing_time_ms (0): 10.9 (-33%)
• batch_insert_into_append_only_tree_32_depth_ms (4096): 1,714 (-33%)
• batch_insert_into_append_only_tree_32_depth_hash_ms (4096): 0.412 (-33%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 46b15e3d and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,376	239,224	469,484
l1_rollup_execution_gas	647,474	929,582	1,305,664
l2_block_processing_time_in_ms	1,320 (-3%)	4,842 (+2%)	9,413 (-9%)
note_successful_decrypting_time_in_ms	154 (-5%)	534 (+10%)	949 (-7%)
note_trial_decrypting_time_in_ms	60.2 (-8%)	49.5 (-51%)	80.9 (+60%)
l2_block_building_time_in_ms	17,992 (-1%)	68,107 (-6%)	134,775 (-4%)
l2_block_rollup_simulation_time_in_ms	8,000 (-1%)	28,524 (-5%)	55,644 (-2%)
l2_block_public_tx_process_time_in_ms	9,972 (-1%)	39,525 (-7%)	79,036 (-6%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,070 (+3%)	26,955
note_history_successful_decrypting_time_in_ms	1,233	2,469 (+2%)
note_history_trial_decrypting_time_in_ms	60.9 (-1%)	163 (+35%)
node_database_size_in_bytes	18,645,072	34,889,808
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	283	44,366	28,244
private-kernel-ordering	219 (+1%)	52,868	14,326
base-parity	1,820 (-1%)	128	311
base-rollup	711 (-2%)	165,787	925
root-parity	1,547 (-2%)	1,244	311
root-rollup	51.4 (-1%)	4,487	725
private-kernel-inner	655 (+1%)	73,771	28,244
public-kernel-app-logic	446 (-3%)	35,260	28,215
public-kernel-tail	172 (-3%)	40,926	28,215
merge-rollup	8.28	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.7 (+5%)	16.0 (-3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.613 (+3%)	0.494 (-3%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	45.7 (-1%)	72.1	230	445	881	⚠️ 1,714 (-33%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.470 (-1%)	0.445	0.419	0.417	0.418	⚠️ 0.412 (-33%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.6 (-1%)	107 (-8%)	336 (+1%)	663	1,309	2,618 (-15%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.478 (-1%)	0.484 (-8%)	0.459 (+1%)	0.456	0.453	0.456 (-15%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.3 (-1%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.537 (-1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,012

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,257 (-1%)	1,772 (+1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	⚠️ 10.9 (-33%)	1,242 (-2%)

[Maddiaa0]

overall lgtm, we will need to address Lasse's point, maybe a different code path for public and private here?

I changed the code too much