feat: introduce max_block_number

[nventuro]

Part of #4761.

This adds a new validity condition to transactions called max_block_number, causing them to fail if the current block is larger than a requested max block. This can be used to construct proofs that are only valid if included before a certain block (which is exactly how SharedMutableStorage/SlowJoe/SlowUpdatesTree2.0 works).

---

I made max_block_number an Option<u32> both to not have to include a initial value equal to the largest block, and also to avoid issues that arise from abuse of std::unsafe::zeroed. Many parts of the stack assume a (mostly) zeroed transaction is a valid one, but a max_block_number value of 0 is not useful. With Option, a zeroed value means no max block number was requested (is_none() returns true), and this entire issue is avoided.

This property is initially set to is_none(), meaning there's no max block number constraint. The PrivateContext now has a request_max_block_number function that can be used to add constraints. Each time a lower max block number is seen it replaces the current one. The private kernel aggregates these across private calls and ends up with the smallest one.

This value is stored in a new struct called RollupValidationRequests, an extension from @LeilaWang's work in #5236. These are validation requests accumulated during private and public execution that are forwarded to the rollup for it to check. Currently we only have max_block_number, but there may be more. Note that we currently have a slight duplication in the public kernal tail public inputs, but this is expected to be sorted out very soon as this struct is refactored.

---

Note that in the end to end tests we're only testing that the sequencer drops the transaction, but not that the base rollup rejects this transaction (this is only tested in the rollup circuit unit tests). Testing this would require bypassing the sequencer tx validation logic and manually building a block, but this is a fairly involved endeavor and one that our infrastructure does not currently easily support. I'm still looking into a way to add this test.

[nventuro]

#5236 moved things out of non-revertible accumulated data, and the new ValidationRequests is a much better place to store max_block_number, so I'm moving it there as part of the merge resolution.

Narrator: this proved to be much harder than anticipated.

[github-actions]

Changes to circuit sizes

Generated at commit: e20278d475ed2fa9ce693a6abd5030f540afec2f, compared to commit: 5d669b93d1210262afe246976904f1e86d6ff518

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_teardown_simulated	+4 ❌	+0.44%	+8 ❌	+0.44%
public_kernel_setup_simulated	+4 ❌	+0.44%	+8 ❌	+0.44%
public_kernel_tail_simulated	+4 ❌	+0.44%	+8 ❌	+0.44%
public_kernel_app_logic_simulated	+4 ❌	+0.44%	+8 ❌	+0.44%
private_kernel_tail_simulated	+2 ❌	+0.44%	+4 ❌	+0.44%
private_kernel_init_simulated	+2 ❌	+0.22%	+4 ❌	+0.22%
private_kernel_inner_simulated	+2 ❌	+0.22%	+4 ❌	+0.22%
private_kernel_inner	+33 ❌	+0.03%	+655 ❌	+0.13%
public_kernel_teardown	+14 ❌	+0.05%	+20 ❌	+0.01%
public_kernel_setup	+8 ❌	+0.03%	+14 ❌	+0.01%
public_kernel_app_logic	+14 ❌	+0.02%	+19 ❌	+0.01%
public_kernel_tail	+8 ❌	+0.01%	+13 ❌	+0.00%
private_kernel_init	+7 ❌	+0.01%	+10 ❌	+0.00%
rollup_base	+20 ❌	+0.01%	+36 ❌	+0.00%
private_kernel_tail	+4 ❌	+0.00%	+7 ❌	+0.00%

---

Full diff report 👇

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_teardown_simulated	907 (+4)	+0.44%	1,817 (+8)	+0.44%
public_kernel_setup_simulated	907 (+4)	+0.44%	1,817 (+8)	+0.44%
public_kernel_tail_simulated	907 (+4)	+0.44%	1,817 (+8)	+0.44%
public_kernel_app_logic_simulated	907 (+4)	+0.44%	1,817 (+8)	+0.44%
private_kernel_tail_simulated	453 (+2)	+0.44%	909 (+4)	+0.44%
private_kernel_init_simulated	904 (+2)	+0.22%	1,811 (+4)	+0.22%
private_kernel_inner_simulated	904 (+2)	+0.22%	1,811 (+4)	+0.22%
private_kernel_inner	95,864 (+33)	+0.03%	520,053 (+655)	+0.13%
public_kernel_teardown	29,411 (+14)	+0.05%	182,854 (+20)	+0.01%
public_kernel_setup	29,338 (+8)	+0.03%	182,780 (+14)	+0.01%
public_kernel_app_logic	56,066 (+14)	+0.02%	314,153 (+19)	+0.01%
public_kernel_tail	124,970 (+8)	+0.01%	358,966 (+13)	+0.00%
private_kernel_init	48,599 (+7)	+0.01%	348,612 (+10)	+0.00%
rollup_base	171,479 (+20)	+0.01%	1,730,736 (+36)	+0.00%
private_kernel_tail	373,476 (+4)	+0.00%	839,580 (+7)	+0.00%

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 5d669b93 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	676	676	676
l1_rollup_calldata_gas	6,424	6,424	6,424
l1_rollup_execution_gas	585,757	585,757	585,757
l2_block_processing_time_in_ms	1,378 (+7%)	4,748	9,291 (+3%)
note_successful_decrypting_time_in_ms	182 (-2%)	530 (+2%)	1,015 (+7%)
note_trial_decrypting_time_in_ms	85.7 (-7%)	52.8 (+44%)	36.0 (-57%)
l2_block_building_time_in_ms	17,417 (+1%)	65,566 (+1%)	129,754 (-1%)
l2_block_rollup_simulation_time_in_ms	8,054 (+1%)	28,463 (+1%)	55,676 (-3%)
l2_block_public_tx_process_time_in_ms	9,342 (+2%)	37,047 (+1%)	73,955 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,429 (+2%)	26,450
note_history_successful_decrypting_time_in_ms	1,216 (-3%)	2,433
note_history_trial_decrypting_time_in_ms	62.7 (-34%)	140 (+14%)
node_database_size_in_bytes	18,628,688	34,959,440
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	245 (+2%)	44,377	28,214
private-kernel-ordering	215	52,880	14,296
base-parity	4,492 (+1%)	128	311
root-parity	1,620 (-6%)	1,244	311
base-rollup	18,044 (-2%)	165,760	861
root-rollup	50.1	4,359	725
private-kernel-inner	605 (+2%)	73,794	28,214
public-kernel-app-logic	401 (+1%)	35,251	28,217
public-kernel-tail	174 (+1%)	40,928	28,217
merge-rollup	9.54 (+15%)	2,568	861

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.0	15.9 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.581	0.492	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.0	72.1	234 (-1%)	442 (-1%)	867	1,716	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.472	0.445	0.425 (-1%)	0.414	0.412	0.410	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	53.7	107	336	671 (+2%)	1,316 (+1%)	2,608 (-1%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.479	0.480	0.457	0.463 (+2%)	0.455 (+1%)	0.452 (-1%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.1
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.535

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	22,024

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	3,044 (-1%)	1,680 (+2%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	13.3 (+23%)	1,153 (+1%)

[AztecBot]

Docs Preview

Hey there! 👋 You can check your preview at https://65fdc19ceb20373c581facd2--aztec-docs-dev.netlify.app