Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Keys_Viewing): Compute ciphertext header #5867

Closed
Tracked by #5606
LHerskind opened this issue Apr 19, 2024 · 0 comments · Fixed by #6175
Closed
Tracked by #5606

feat(Keys_Viewing): Compute ciphertext header #5867

LHerskind opened this issue Apr 19, 2024 · 0 comments · Fixed by #6175
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Apr 19, 2024

For AES in noir: preferably use #5866, otherwise use #5895 if required.

Implementation in noir.

From #5896 should be functionality to compute the symmetric key.

We need to compute the ciphertext header, which currently seems to just be the contract_address for the note.

As with many of the others, better description is in the diagam linked at the main issue.

As the flows for both incoming and outgoing is the same, simply with different pub keys, it seems fine to just have one function implementation.

image

@LHerskind LHerskind assigned LHerskind and unassigned nventuro May 3, 2024
LHerskind added a commit that referenced this issue May 7, 2024
Fixes #5867 with the AES oracle on the noir side and a encrypt/decrypt
tool on the typescript side as well.

Changes the symmetric key derivation to use `GrumpkinPrivateKey` instead
of the `GrumpkinScalar`, this changes the order of low/high.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants