Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Get rid of unnecessary propose functions #8452

Closed
Tracked by #7820
LHerskind opened this issue Sep 9, 2024 · 2 comments
Closed
Tracked by #7820

refactor: Get rid of unnecessary propose functions #8452

LHerskind opened this issue Sep 9, 2024 · 2 comments
Assignees
@LHerskind
Milestone
Sequencer & Prove...

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Sep 9, 2024 •
edited
Loading

Some of the propose functions that exists in the Rollup deserve death. As we are moving towards blobs, we might as well reject the case where body is not provided as part of the proposal. Also, we can get rid of the case where no signatures are provided since that is trivial to handle at the typescript caller and should not pollute the contracts.
@LHerskind LHerskind self-assigned this Sep 9, 2024
@LHerskind LHerskind mentioned this issue Sep 9, 2024
Merged
@LHerskind
Copy link
Contributor Author

Handling the based fallback etc should become slightly easier to follow when there are no longer unnecessary variants in there.

@LHerskind LHerskind added this to the Sequencer & Prover Testnet milestone Sep 10, 2024
This was referenced Sep 10, 2024
Closed
Merged
Maddiaa0 pushed a commit that referenced this issue Sep 11, 2024
@LHerskind
refactor: remove unneeded propose and da oracle (#8474)
274a6b7 
Fixes #8471 and #8452. 

Removes the need for `AVAILABILITY_ORACLE_CONTRACT_ADDRESS`.
@LHerskind
Copy link
Contributor Author

This was fixed as part of #8474

@LHerskind LHerskind mentioned this issue Sep 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
None yet
Projects
A3
Archived in project
Milestone
Sequencer & Prover Testnet
Development

No branches or pull requests
1 participant
@LHerskind