Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update acir tests to reflect compilation based off of package name #1405

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Aug 3, 2023

ACIR tests are failing and needed a refresh on the Noir side. However, there has been a change where compilation is specified off of the package name in the Nargo.toml rather than a specified file name such as main.json

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • [] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@vezenovm vezenovm requested a review from ludamad August 3, 2023 14:20
@vezenovm
Copy link
Contributor Author

vezenovm commented Aug 3, 2023

@ludamad acir tests passing here

@vezenovm
Copy link
Contributor Author

vezenovm commented Aug 3, 2023

Actually don't bother reviewing yet as I will have to change the branch back to master once the Noir PR is merged and it will dismiss your review

@vezenovm vezenovm enabled auto-merge (squash) August 3, 2023 15:04
@vezenovm vezenovm merged commit bb38c7a into master Aug 3, 2023
@vezenovm vezenovm deleted the mv/acir-tests-update branch August 3, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants