Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Pull noir #4534

Closed
wants to merge 10 commits into from
Closed

chore: Pull noir #4534

wants to merge 10 commits into from

Conversation

sirasistant
Copy link
Contributor

Please read contributing guidelines and remove this line.

@sirasistant
git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
f664603
@sirasistant
git subrepo pull (merge) noir
c03137b 
subrepo:
  subdir:   "noir"
  merged:   "5700263e0"
upstream:
  origin:   "https://github.com/noir-lang/noir"
  branch:   "aztec-packages"
  commit:   "2521150ed"
git-subrepo:
  version:  "0.4.6"
  origin:   "???"
  commit:   "???"
@sirasistant
chore: updated lockfile
e382c8a
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2024

Changes to circuit sizes

Generated at commit: cc1a87cf3ca92ad6446a7ba671fd8308807a3916, compared to commit: 47d66f9119cad1a82b621d30acab88f47886e063

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_public_previous +407 ❌ +0.87% +1,606 ❌ +0.64%
public_kernel_private_previous +407 ❌ +0.87% +1,606 ❌ +0.64%
private_kernel_inner +650 ❌ +0.70% +2,590 ❌ +0.50%
private_kernel_ordering -10 ✅ -0.01% -7 ✅ -0.00%
public_kernel_public_previous_simulated -298 ✅ -26.73% -3,257 ✅ -66.55%
private_kernel_inner_simulated -298 ✅ -26.73% -3,257 ✅ -66.55%
public_kernel_private_previous_simulated -298 ✅ -26.73% -3,257 ✅ -66.55%
private_kernel_init_simulated -298 ✅ -26.73% -3,257 ✅ -66.55%
private_kernel_ordering_simulated -190 ✅ -27.03% -3,068 ✅ -74.88%
rollup_base_simulated -10 ✅ -90.91% -2,756 ✅ -98.68%
Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_public_previous 47,282 (+407) +0.87% 252,933 (+1,606) +0.64%
public_kernel_private_previous 47,290 (+407) +0.87% 252,941 (+1,606) +0.64%
private_kernel_inner 93,278 (+650) +0.70% 522,690 (+2,590) +0.50%
private_kernel_ordering 196,159 (-10) -0.01% 504,318 (-7) -0.00%
public_kernel_public_previous_simulated 817 (-298) -26.73% 1,637 (-3,257) -66.55%
private_kernel_inner_simulated 817 (-298) -26.73% 1,637 (-3,257) -66.55%
public_kernel_private_previous_simulated 817 (-298) -26.73% 1,637 (-3,257) -66.55%
private_kernel_init_simulated 817 (-298) -26.73% 1,637 (-3,257) -66.55%
private_kernel_ordering_simulated 513 (-190) -27.03% 1,029 (-3,068) -74.88%
rollup_base_simulated 1 (-10) -90.91% 37 (-2,756) -98.68%

@sirasistant
Copy link
Contributor Author

superceded by #4546

@ludamad ludamad deleted the arv/pull_noir_master branch August 22, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

@charlielye charlielye Awaiting requested review from charlielye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @ludamad @TomAFrench