chore: aztec-macros refactor

[Thunkar]

Partially addresses #5080

Until we have full macro support in noir, this PR aims to make using what we currently have a little bit less painful.
The crate is now divided into utils of several kind (ast manipulation, error handling, hir manipulation...) and transforms.

A transform is an end-to-end modification to the noir code that generates a valid compilation result from a given contract. This makes it easier to manipulate (and hopefully soon, replace) said modifications atomically, improving readability.

This also modifies the first macro pass to iterate over all crates, not only the root one, which allows us to implement more stuff without having to dig deep into the def collector or (god forbid) the interner.

The second macro pass has been renamed to process_collected_defs. Tried to generalize it a bit more, but providing a mutable ref for the whole def_collector turned out to be tricky without cloning def_maps, so it's staying like it is now.

[AztecBot]

Benchmark results

Metrics with a significant change:

• note_successful_decrypting_time_in_ms (32): 476 (-28%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9ca41ef6 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,668	18,820	36,356
l1_rollup_calldata_gas	66,028	238,684	468,608
l1_rollup_execution_gas	666,508	953,393	1,335,764
l2_block_processing_time_in_ms	1,324 (+2%)	4,614	8,764 (-7%)
note_successful_decrypting_time_in_ms	141 (-6%)	⚠️ 476 (-28%)	1,007 (+2%)
note_trial_decrypting_time_in_ms	45.6 (-19%)	91.1 (+19%)	40.7 (-65%)
l2_block_building_time_in_ms	12,429 (-1%)	49,074	96,840 (-1%)
l2_block_rollup_simulation_time_in_ms	7,344 (-1%)	29,111	57,495
l2_block_public_tx_process_time_in_ms	5,055	19,896 (-1%)	39,232 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	13,940	25,496 (-6%)
note_history_successful_decrypting_time_in_ms	1,191 (+1%)	2,340 (-3%)
note_history_trial_decrypting_time_in_ms	65.2 (+9%)	180 (+8%)
node_database_size_in_bytes	18,657,360	35,524,688 (+1%)
pxe_database_size_in_bytes	29,859	59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	272	44,338	27,700
private-kernel-ordering	205 (-1%)	52,324	14,326
base-rollup	652 (-2%)	177,083	925
root-rollup	67.8 (-1%)	4,176	789
private-kernel-inner	361	73,197	27,700
public-kernel-app-logic	179 (-1%)	34,582	27,671
public-kernel-tail	91.5 (-1%)	34,206	27,671
merge-rollup	8.14 (-1%)	2,696	925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2 (+1%)	15.7 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.6	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.593 (+1%)	0.487 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	46.1 (-3%)	70.9 (-1%)	231	432 (-2%)	864	1,668 (-2%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	96.0	159	543	1,055	2,079	4,127	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.474 (-3%)	0.438 (-1%)	0.422	0.405 (-3%)	0.411	0.400 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	52.9 (-1%)	105 (-1%)	336	641 (-2%)	1,293 (-1%)	2,548 (-2%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	104	207	691	1,363	2,707	5,395	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.472 (-1%)	0.474 (-1%)	0.458	0.442 (-2%)	0.450 (-1%)	0.444 (-2%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	59.8 (-2%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	109
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.525 (-2%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes
tx_size_in_bytes	19,191

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,805 (-1%)	1,429 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	9.87 (-7%)	610 (-1%)

[sirasistant]

Just some nits!

[vezenovm]

Much nicer to have this package split up