Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: move entrypoints back to aztec.js #5312

Closed

Conversation

alexghr
Copy link
Contributor

@alexghr alexghr commented Mar 19, 2024

Moves the entrypoints back into aztec.js, but in a dedicated submodule so that code entrypoint-specific code can be reused in other aztec.js modules.

Copy link
Contributor Author

alexghr commented Mar 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @alexghr and the rest of your teammates on Graphite Graphite

@AztecBot
Copy link
Collaborator

AztecBot commented Mar 19, 2024

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (64): 100 (+107%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 161c3136 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,668 18,852 36,420
l1_rollup_calldata_gas 66,424 239,244 468,648
l1_rollup_execution_gas 648,162 932,162 1,309,948
l2_block_processing_time_in_ms 1,325 (+7%) 4,770 (+3%) 9,080 (+2%)
note_successful_decrypting_time_in_ms 175 (-5%) 522 (+8%) 967 (+5%)
note_trial_decrypting_time_in_ms 78.6 (-11%) 41.4 (-57%) ⚠️ 100 (+107%)
l2_block_building_time_in_ms 17,802 (+3%) 67,296 (+3%) 133,078 (+3%)
l2_block_rollup_simulation_time_in_ms 8,024 (+4%) 28,557 (+4%) 55,849 (+4%)
l2_block_public_tx_process_time_in_ms 9,757 (+3%) 38,681 (+3%) 77,131 (+3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,134 (+6%) 31,158 (+11%)
note_history_successful_decrypting_time_in_ms 1,268 (-3%) 2,429 (-3%)
note_history_trial_decrypting_time_in_ms 98.3 (-5%) 150 (-13%)
node_database_size_in_bytes 18,628,688 35,098,704
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 281 (+1%) 44,366 28,245
private-kernel-ordering 216 (+2%) 52,869 14,327
base-parity 1,809 (+2%) 128 311
base-rollup 719 (+2%) 165,788 925
root-parity 1,617 (+4%) 1,244 311
root-rollup 51.5 (+1%) 4,487 725
private-kernel-inner 644 (+2%) 73,772 28,245
public-kernel-app-logic 444 (+5%) 35,260 28,215
public-kernel-tail 178 (+5%) 40,926 28,215
merge-rollup 8.29 (+1%) 2,696 925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.5 (+7%) 16.3 (+3%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.615 (+7%) 0.505 (+3%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.3 (+3%) 72.2 (+2%) 229 (+4%) 490 (+10%) 876 (+5%) 1,717 (+4%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.476 (+3%) 0.446 (+2%) 0.419 (+3%) 0.460 (+10%) 0.414 (+4%) 0.412 (+4%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.0 (+2%) 106 (+2%) 335 (+4%) 662 1,312 (+4%) 2,600 (+4%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.482 (+2%) 0.479 (+2%) 0.456 (+4%) 0.457 0.453 (+4%) 0.452 (+3%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 64.5 (+7%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.564 (+7%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes
tx_size_in_bytes 22,013

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 3,217 (+2%) 1,757 (+1%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 11.3 (-17%) 1,250 (+5%)

@alexghr alexghr force-pushed the 03-19-refactor_move_entrypoints_back_to_aztec.js branch from 6f3eebf to 383a13c Compare March 21, 2024 09:47
@alexghr
Copy link
Contributor Author

alexghr commented Mar 21, 2024

This is not needed anymore and #5313 will be rebased on top of master

@alexghr alexghr closed this Mar 21, 2024
@ludamad ludamad deleted the 03-19-refactor_move_entrypoints_back_to_aztec.js branch August 22, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants