Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #5480

Closed
wants to merge 2 commits into from
Closed

feat: Sync from noir #5480

wants to merge 2 commits into from

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: install dependencies for building docs dependencies (noir-lang/noir#4646)
chore: add missing brace to workflow (noir-lang/noir#4654)
chore: delete R1CSTransformer (noir-lang/noir#4649)
fix: Slice coercions (noir-lang/noir#4640)
chore(ci): add warning sticky comment (noir-lang/noir#4647)
fix(ssa): Fix slice intrinsic handling in the capacity tracker (noir-lang/noir#4643)
chore: fix versioning of bn254_blackbox_solver crate (noir-lang/noir#4638)
chore: fix acvm crates reporting errors as JS packages (noir-lang/noir#4637)
chore: Release Noir(0.26.0) (noir-lang/noir#4526)
chore: convert BlockExpression into a standard struct (noir-lang/noir#4623)
chore(github): Improve PR template "document later" checkbox description (noir-lang/noir#4625)
chore: Update integers.md to note support for Fields using from_integer (noir-lang/noir#4536)
chore: update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466)
feat: add specific error for attempting string[x] = ".." (noir-lang/noir#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610)
END_COMMIT_OVERRIDE

AztecBot and others added 2 commits March 27, 2024 16:00
noir-lang/noir#4646)

chore: add missing brace to workflow (noir-lang/noir#4654)
chore: delete `R1CSTransformer` (noir-lang/noir#4649)
fix: Slice coercions (noir-lang/noir#4640)
chore(ci): add warning sticky comment (noir-lang/noir#4647)
fix(ssa): Fix slice intrinsic handling in the capacity tracker  (noir-lang/noir#4643)
chore: fix versioning of `bn254_blackbox_solver` crate (noir-lang/noir#4638)
chore: fix acvm crates reporting errors as JS packages (noir-lang/noir#4637)
chore: Release Noir(0.26.0) (noir-lang/noir#4526)
chore: convert `BlockExpression` into a standard struct (noir-lang/noir#4623)
chore(github): Improve PR template "document later" checkbox description (noir-lang/noir#4625)
chore: Update integers.md to note support for Fields using `from_integer` (noir-lang/noir#4536)
chore: update docs with function names to match version 0.25.0 specifications (noir-lang/noir#4466)
feat: add specific error for attempting `string[x] = ".."` (noir-lang/noir#4611)
fix(ssa): Use accurate type during SSA AsSlice simplficiation (noir-lang/noir#4610)
@AztecBot
Copy link
Collaborator Author

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (8): 231 (+43%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 54aee589 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 676 676 676
l1_rollup_calldata_gas 6,424 6,424 6,412
l1_rollup_execution_gas 585,757 585,757 585,745
l2_block_processing_time_in_ms 1,373 (+5%) 4,869 (+1%) 9,692 (+5%)
note_successful_decrypting_time_in_ms ⚠️ 231 (+43%) 579 (+8%) 959 (-1%)
note_trial_decrypting_time_in_ms 36.8 (-45%) 100 (+72%) 87.3 (-9%)
l2_block_building_time_in_ms 13,671 50,958 (+1%) 101,642 (+1%)
l2_block_rollup_simulation_time_in_ms 7,998 (+1%) 28,588 (+3%) 56,547 (+4%)
l2_block_public_tx_process_time_in_ms 5,651 (-1%) 22,317 (-2%) 45,000 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,963 (-2%) 27,546 (+3%)
note_history_successful_decrypting_time_in_ms 1,319 (-3%) 2,462 (-1%)
note_history_trial_decrypting_time_in_ms 104 (-5%) 147 (-7%)
node_database_size_in_bytes 18,673,744 35,115,088
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 229 (+1%) 44,379 28,214
private-kernel-ordering 202 52,880 14,296
base-parity 3,682 (+4%) 128 311
root-parity 1,288 (+10%) 1,244 311
base-rollup 16,879 (+3%) 165,760 861
root-rollup 50.3 (+2%) 4,359 725
private-kernel-inner 295 73,795 28,214
public-kernel-app-logic 121 35,252 28,217
public-kernel-tail 165 40,928 28,217
merge-rollup 9.15 (+10%) 2,568 861
public-kernel-teardown 117 (-2%) 35,252 28,217
public-kernel-setup 115 (-2%) 35,252 28,217

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.1 (+1%) 16.3 (+2%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.589 (+1%) 0.504 (+2%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.8 (-1%) 72.2 236 (+2%) 447 870 (-1%) 1,830 (+6%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.480 (-1%) 0.445 0.424 (+1%) 0.418 0.414 (-1%) 0.438 (+6%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 54.2 (-2%) 107 (-1%) 334 (-2%) 661 1,306 (-1%) 2,858 (+9%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.479 (-2%) 0.484 0.456 (-2%) 0.456 0.453 0.495 (+8%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 61.2
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.535

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 14,968 495,320

Transaction size based on fee payment method

Metric none fee payment method native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 773 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 2,063 (-1%) 1,368 4,704 (-1%)
Metric 0 public data writes 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 11.2 (+10%) 702 521 (-1%) 1,436 584 2,491 (-1%) 668 (-1%)

@TomAFrench TomAFrench closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants