Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #6138

Merged
merged 33 commits into from
May 1, 2024
Merged

feat: Sync from noir #6138

merged 33 commits into from
May 1, 2024

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented May 1, 2024

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: Require for all foldable functions to use distinct return (noir-lang/noir#4949)
feat!: use distinct return value witnesses by default (noir-lang/noir#4951)
chore(docs): adding matomo tracking (noir-lang/noir#4898)
chore: fix typo in ResolverError::AbiAttributeOutsideContract (noir-lang/noir#4933)
chore: Add test for recursing a foldable function (noir-lang/noir#4948)
feat: Handle no_predicates attribute (noir-lang/noir#4942)
fix: ensure where clauses propagated to trait default definitions (noir-lang/noir#4894)
chore: Remove unnecessary pub(super) in interpreter (noir-lang/noir#4939)
END_COMMIT_OVERRIDE

AztecBot and others added 5 commits May 1, 2024 19:49
…eturn (noir-lang/noir#4949)

feat!: use `distinct` return value witnesses by default (noir-lang/noir#4951)
chore(docs): adding matomo tracking (noir-lang/noir#4898)
chore: fix typo in `ResolverError::AbiAttributeOutsideContract` (noir-lang/noir#4933)
chore: Add test for recursing a foldable function (noir-lang/noir#4948)
feat: Handle `no_predicates` attribute (noir-lang/noir#4942)
fix: ensure where clauses propagated to trait default definitions (noir-lang/noir#4894)
chore: Remove unnecessary `pub(super)` in interpreter (noir-lang/noir#4939)
@TomAFrench TomAFrench requested a review from vezenovm May 1, 2024 20:36
@TomAFrench
Copy link
Member

Just realised I can approve these myself as the bot opened the PR not me 😆

vezenovm added 17 commits May 1, 2024 21:43
Copy link
Contributor

github-actions bot commented May 1, 2024

Changes to circuit sizes

Generated at commit: 32722bc57870229a5e0784baf6190da2c7b4300a, compared to commit: af3192dce60c3907898a839ea8db47262da5b78e

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root +24 ❌ +1.73% +24 ❌ +0.01%
rollup_base +30 ❌ +0.02% +31 ❌ +0.00%
rollup_merge +30 ❌ +11.03% 0 ➖ 0.00%
public_kernel_tail_simulated -248 ✅ -99.60% -248 ✅ -49.50%
private_kernel_tail_simulated -248 ✅ -99.60% -248 ✅ -49.50%
private_kernel_inner_simulated -1,086 ✅ -99.91% -1,086 ✅ -49.89%
private_kernel_init_simulated -1,086 ✅ -99.91% -1,086 ✅ -49.89%
private_kernel_tail_to_public_simulated -1,654 ✅ -99.94% -1,654 ✅ -49.92%
public_kernel_app_logic_simulated -1,654 ✅ -99.94% -1,654 ✅ -49.92%
public_kernel_setup_simulated -1,654 ✅ -99.94% -1,654 ✅ -49.92%
public_kernel_teardown_simulated -1,654 ✅ -99.94% -1,654 ✅ -49.92%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_root 1,409 (+24) +1.73% 299,098 (+24) +0.01%
rollup_base 165,044 (+30) +0.02% 1,716,661 (+31) +0.00%
rollup_merge 302 (+30) +11.03% 45,970 (0) 0.00%
public_kernel_tail_simulated 1 (-248) -99.60% 253 (-248) -49.50%
private_kernel_tail_simulated 1 (-248) -99.60% 253 (-248) -49.50%
private_kernel_inner_simulated 1 (-1,086) -99.91% 1,091 (-1,086) -49.89%
private_kernel_init_simulated 1 (-1,086) -99.91% 1,091 (-1,086) -49.89%
private_kernel_tail_to_public_simulated 1 (-1,654) -99.94% 1,659 (-1,654) -49.92%
public_kernel_app_logic_simulated 1 (-1,654) -99.94% 1,659 (-1,654) -49.92%
public_kernel_setup_simulated 1 (-1,654) -99.94% 1,659 (-1,654) -49.92%
public_kernel_teardown_simulated 1 (-1,654) -99.94% 1,659 (-1,654) -49.92%

@vezenovm vezenovm enabled auto-merge (squash) May 1, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants