feat: constrain note encryption

[LHerskind]

Fixes #6408.

Chans the noir implementation of incoming body slightly to easily fit in with the broadcast format currently in use.

Have some todo's in the payload.nr file, mainly to use meaningful outgoing keys #6410 and to use tags when we get to it.

For the eph_sk also pulling only a Fr while we use it for Fq so we are slightly biased. @iAmMichaelConnor if you got some news on if this is acceptable would be cool 👀. Using the unsafe random atm.

[LHerskind]

• feat: constrain note encryption #6432 👈
• feat: Update the encrypted note log format #6411
• feat: full encryption and decryption of log in ts #6348
• feat: add encrypted log outgoing body #6334
• refactor: cleanup the encrypted log incoming body #6325
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite

[LHerskind]

No longer blocked by noir since we throw away the app siloed viewing key as they were useless.

[AztecBot]

Benchmark results

Metrics with a significant change:

• protocol_circuit_simulation_time_in_ms (public-kernel-setup): 443 (-33%)
• protocol_circuit_simulation_time_in_ms (public-kernel-teardown): 364 (-36%)
• protocol_circuit_input_size_in_bytes (public-kernel-setup): 88,767 (-18%)
• protocol_circuit_input_size_in_bytes (public-kernel-teardown): 87,906 (-19%)
• protocol_circuit_output_size_in_bytes (public-kernel-setup): 72,273 (-16%)
• protocol_circuit_output_size_in_bytes (public-kernel-teardown): 71,636 (-17%)
• protocol_circuit_witness_generation_time_in_ms (base-parity): 1,087 (-36%)
• protocol_circuit_witness_generation_time_in_ms (base-rollup): 5,973 (+155%)
• protocol_circuit_witness_generation_time_in_ms (root-parity): 176 (+268%)
• protocol_circuit_witness_generation_time_in_ms (public-kernel-setup): 1,093 (-59%)
• protocol_circuit_witness_generation_time_in_ms (public-kernel-app-logic): 1,123 (-69%)
• protocol_circuit_witness_generation_time_in_ms (public-kernel-teardown): 1,078 (-70%)
• protocol_circuit_witness_generation_time_in_ms (public-kernel-tail): 6,564 (-71%)
• protocol_circuit_witness_generation_time_in_ms (root-rollup): 128 (+107%)
• protocol_circuit_proving_time_in_ms (base-parity): 8,001 (+225%)
• protocol_circuit_proving_time_in_ms (base-rollup): 136,001 (+94%)
• protocol_circuit_proving_time_in_ms (root-parity): 112,902 (+234%)
• protocol_circuit_proving_time_in_ms (public-kernel-setup): 15,048 (-60%)
• protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 11,836 (-69%)
• protocol_circuit_proving_time_in_ms (public-kernel-teardown): 11,528 (-70%)
• protocol_circuit_proving_time_in_ms (public-kernel-tail): 48,468 (-69%)
• protocol_circuit_proof_size_in_bytes (public-kernel-setup): 82,485 (-29%)
• protocol_circuit_proof_size_in_bytes (public-kernel-app-logic): 78,200 (-33%)
• protocol_circuit_proof_size_in_bytes (public-kernel-teardown): 78,200 (-33%)
• l2_block_building_time_in_ms (4): 167,730 (+669%)
• l2_block_rollup_simulation_time_in_ms (4): 167,623 (+673%)
• l2_block_public_tx_process_time_in_ms (4): 12,800 (-31%)
• l1_rollup_calldata_size_in_bytes (4): 1,076 (-24%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,721	1,540	700	750 (+1%)	769
proof_construction_time_sha256_30_ms	11,417	3,063	1,369	1,437 (+1%)	1,449
proof_construction_time_sha256_100_ms	43,705	11,729	5,410	5,415 (+1%)	5,339 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0	89.0 (+1%)
proof_construction_time_poseidon_hash_30_ms	1,520	418	201 (-1%)	225	265 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,740	1,573	727	772 (-3%)	794

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	⚠️ 1,076 (-24%)	1,412	1,412
l1_rollup_calldata_gas	8,078 (-15%)	9,454	9,440
l1_rollup_execution_gas	598,554 (-2%)	610,275	610,261
l2_block_processing_time_in_ms	707 (+3%)	1,293 (+4%)	2,490 (+4%)
l2_block_building_time_in_ms	⚠️ 167,730 (+669%)	45,494 (+2%)	88,186 (+5%)
l2_block_rollup_simulation_time_in_ms	⚠️ 167,623 (+673%)	45,147 (+2%)	87,765 (+5%)
l2_block_public_tx_process_time_in_ms	⚠️ 12,800 (-31%)	41,755 (+2%)	84,503 (+5%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	5,901 (+3%)	8,527 (+4%)
node_database_size_in_bytes	9,478,224	12,763,216
pxe_database_size_in_bytes	9,242	15,127

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	131	468 (-4%)	13,885 (+10%)	20,219 (-2%)	61,299 (-5%)	89,536	2,731	524,288
private-kernel-inner	380 (-1%)	941 (-6%)	51,487 (+13%)	88,227 (-4%)	60,972 (-6%)	89,536	2,731	2,097,152
private-kernel-tail	367 (+2%)	1,774 (-9%)	45,414 (+15%)	96,545	68,261	11,648	297	2,097,152
base-parity	7.04 (+9%)	⚠️ 1,087 (-36%)	⚠️ 8,001 (+225%)	128	64.0	2,208	2.00	131,072
root-parity	48.7 (-3%)	⚠️ 176 (+268%)	⚠️ 112,902 (+234%)	27,094	64.0	2,720	18.0	2,097,152
base-rollup	5,850 (-7%)	⚠️ 5,973 (+155%)	⚠️ 136,001 (+94%)	118,777 (-1%)	774 (+2%)	3,285 (-10%)	47.0	4,194,304
root-rollup	102 (-8%)	⚠️ 128 (+107%)	19,897 (+2%)	22,999 (-9%)	648 (+5%)	3,440	41.0	1,048,576
public-kernel-app-logic	536 (-3%)	⚠️ 1,123 (-69%)	⚠️ 11,836 (-69%)	105,114 (-3%)	84,362 (-3%)	⚠️ 78,200 (-33%)	3,582	2,097,152
public-kernel-tail	1,067 (-4%)	⚠️ 6,564 (-71%)	⚠️ 48,468 (-69%)	378,863 (-6%)	7,650	10,496 (-10%)	297	8,388,608
private-kernel-reset-small	583 (+2%)	1,926 (-8%)	47,913 (+13%)	120,737	64,614	89,536	2,731	2,097,152
public-kernel-setup	⚠️ 443 (-33%)	⚠️ 1,093 (-59%)	⚠️ 15,048 (-60%)	⚠️ 88,767 (-18%)	⚠️ 72,273 (-16%)	⚠️ 82,485 (-29%)	3,582	2,097,152
public-kernel-teardown	⚠️ 364 (-36%)	⚠️ 1,078 (-70%)	⚠️ 11,528 (-70%)	⚠️ 87,906 (-19%)	⚠️ 71,636 (-17%)	⚠️ 78,200 (-33%)	3,582	2,097,152
private-kernel-reset	548	N/A	N/A	200,856	33,766	N/A	N/A	N/A
private-kernel-ordering	305	N/A	N/A	53,688	34,764	N/A	N/A	N/A
merge-rollup	28.7 (+1%)	244	3,842	16,542	756	3,104	N/A	N/A
private-kernel-tail-to-public	N/A	6,906 (-2%)	55,886 (+15%)	N/A	N/A	116,768	3,582	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,344	9,944	467 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,408	9,944	40.3 (-3%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,920	9,944	1,770	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,312	9,944	1,427 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,304	9,944	2,825 (+2%)	16,768	56,146 (+11%)	2,097,152	457
Token:privately_mint_private_note	1,280	9,944	1,591 (-2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,344	9,944	1,043 (-7%)	16,768	11,135 (+12%)	524,288	457
Token:transfer	1,376	9,944	5,301 (-1%)	16,768	54,303 (+14%)	2,097,152	457
Benchmarking:create_note	1,344	9,944	1,392 (+2%)	N/A	N/A	N/A	N/A
SchnorrAccount:spend_private_authwit	1,280	9,944	81.6 (+8%)	N/A	N/A	N/A	N/A
Token:unshield	1,376	9,944	3,895 (+2%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,376	9,944	4,818 (+2%)	N/A	N/A	N/A	N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves	32 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.6 (+2%)	17.1 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.611 (+2%)	0.524 (+2%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	49.1 (+2%)	76.7 (+2%)	135 (+2%)	247 (+3%)	482 (+4%)	N/A
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	288	543	1,055	N/A
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.501 (+2%)	0.472 (+2%)	0.462 (+1%)	0.448 (+3%)	0.450 (+4%)	N/A
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	60.7 (+4%)	114 (+4%)	187 (+3%)	355 (+3%)	709 (+3%)	N/A
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109 (+1%)	208	355	691	1,363	N/A
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.512 (+3%)	0.509 (+3%)	0.494 (+2%)	0.481 (+3%)	0.487 (+4%)	N/A
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	61.3 (+4%)
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	N/A	N/A	N/A	104 (+1%)
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	N/A	N/A	0.555 (+3%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	76,638 (-4%)	758,773 (+14%)

Transaction size based on fee payment method

| Metric | |
| - | |

[benesjan]

LGTM

[benesjan]

Can we link issue here?

[benesjan]

Can we link issue here?