Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): dont look for tags if pure spot #6446

Merged
merged 1 commit into from
May 16, 2024

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented May 16, 2024

No description provided.

@ludamad ludamad force-pushed the ad/fix/builder-request-status branch from b2d16ea to b321975 Compare May 16, 2024 02:18
@AztecBot
Copy link
Collaborator

Benchmark results

Metrics with a significant change:

  • circuit_witness_generation_time_in_ms (merge-rollup): 276 (+123%)
  • circuit_proving_time_in_ms (merge-rollup): 3,813 (+57%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 740 740 740
l1_rollup_calldata_gas 6,680 6,668 6,692
l1_rollup_execution_gas 586,865 586,853 586,877
l2_block_processing_time_in_ms 1,358 5,072 10,066 (-1%)
l2_block_building_time_in_ms 22,803 89,863 179,471
l2_block_rollup_simulation_time_in_ms 22,663 89,375 178,521
l2_block_public_tx_process_time_in_ms 8,970 35,109 70,342

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 15,602 (+1%) 28,621
node_database_size_in_bytes 22,892,624 39,460,944
pxe_database_size_in_bytes 29,868 59,425

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes circuit_witness_generation_time_in_ms circuit_proving_time_in_ms circuit_proof_size_in_bytes
private-kernel-init 112 16,772 33,766 N/A N/A N/A
private-kernel-inner 312 (-1%) 57,607 33,766 N/A N/A N/A
private-kernel-reset 559 (-1%) 200,856 33,766 N/A N/A N/A
private-kernel-ordering 322 53,688 48,421 N/A N/A N/A
base-parity 7.48 128 64.0 287 (+2%) 13,452 (+1%) 2,208
root-parity 48.5 27,064 64.0 184 (-28%) 184,409 (+2%) 2,720
base-rollup 657 111,094 925 7,733 162,236 (+2%) 3,104
root-rollup 63.8 11,454 789 179 (-4%) 16,570 3,424
public-kernel-app-logic 122 (-1%) 61,017 51,751 296 (+9%) 434 (+5%) 65,344
public-kernel-tail 443 166,458 7,691 482 (+3%) 412 (+2%) 10,112
public-kernel-setup 101 (+2%) 61,017 51,751 311 (-1%) 399 (+4%) 65,344
public-kernel-teardown 103 (+2%) 61,017 51,751 270 (-1%) 342 (-2%) 65,344
merge-rollup 6.54 (+3%) 2,696 925 ⚠️ 276 (+123%) ⚠️ 3,813 (+57%) 3,104

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.0 (-1%) 17.9 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.639 0.548 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.8 80.7 260 (-1%) 508 (+1%) 986 (-1%) 1,947 (-1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.529 0.498 0.474 (-1%) 0.474 (+1%) 0.467 (-1%) 0.465 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 61.2 121 (+1%) 375 (-1%) 746 1,463 (-1%) 2,918 (-1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 106 208 692 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.534 0.540 0.510 (-1%) 0.512 0.507 (-1%) 0.507 (-1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.2
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 108
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.588

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 51,016 1,046,607

Transaction size based on fee payment method

| Metric | |
| - | |

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 2,366 2,123 (-1%) 5,288 (+2%)
Metric 0 public data writes 1 public data writes 2 public data writes 4 public data writes 8 public data writes
tx_sequencer_processing_time_ms 657 899 (-1%) 970 (+2%) 1,757 (+2%) 1,147 (+2%)

@ludamad ludamad merged commit 1d8acfe into master May 16, 2024
93 checks passed
@ludamad ludamad deleted the ad/fix/builder-request-status branch May 16, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants