fix: correctly constrain get header at

[sklppy88]

This PR correctly constrains get header at by taking account the desired block number and adds a test for the specific use case that would pass previously.

[sklppy88]

• fix: correctly constrain get header at #7893 👈
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (FeeJuice:mint_public): 38.8 (-32%)
• avm_simulation_time_ms (Token:mint_public): 72.0 (+65%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 31.2 (-54%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,782	1,561	709	750 (-1%)	767
proof_construction_time_sha256_30_ms	11,877	3,200	1,440 (+2%)	1,459 (+2%)	1,495 (+2%)
proof_construction_time_sha256_100_ms	46,213 (+2%)	12,282 (+1%)	5,602 (+3%)	5,455 (+1%)	5,445 (+1%)
proof_construction_time_poseidon_hash_ms	79.0 (+1%)	34.0	34.0	59.0 (-2%)	87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms	1,533	422	202	224 (-3%)	265 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,670	1,524	688 (+1%)	729 (-4%)	748

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,324	7,844	14,852
l1_rollup_calldata_gas	49,684	92,486	177,524
l1_rollup_execution_gas	1,383,133	2,130,903	3,957,980
l2_block_processing_time_in_ms	256 (-2%)	454 (+3%)	801 (-2%)
l2_block_building_time_in_ms	9,216 (-1%)	18,071	35,854 (-1%)
l2_block_rollup_simulation_time_in_ms	9,215 (-1%)	18,071	35,854 (-1%)
l2_block_public_tx_process_time_in_ms	7,773 (-1%)	16,517 (-1%)	34,278 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,076 (+7%)	3,960 (+5%)
node_database_size_in_bytes	12,652,624	16,732,240
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	91.3 (-5%)	406 (-2%)	21,673	44,858	N/A
private-kernel-inner	163	721	72,309	45,005	N/A
private-kernel-reset-tiny	499 (-3%)	909 (+1%)	65,974	44,844	N/A
private-kernel-tail	207 (-1%)	167	50,728	52,256	N/A
base-parity	5.57 (-1%)	N/A	160	96.0	N/A
root-parity	33.1 (-1%)	N/A	69,084	96.0	N/A
base-rollup	2,840 (-1%)	N/A	187,817	664	N/A
root-rollup	38.8	N/A	54,525	716	N/A
public-kernel-setup	99.6 (-1%)	N/A	103,760	71,222	N/A
public-kernel-app-logic	103 (-1%)	N/A	103,599	71,222	N/A
public-kernel-tail	574 (-1%)	N/A	409,190	16,414	N/A
private-kernel-reset-small	492 (-3%)	N/A	66,085	45,629	N/A
private-kernel-tail-to-public	1,019	664	492,960	1,697	N/A
public-kernel-teardown	93.2 (-2%)	N/A	104,005	71,222	N/A
merge-rollup	19.1	N/A	35,742	664	N/A
undefined	N/A	N/A	N/A	N/A	66,187

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	344 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.2 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	422 (-1%)
FeeJuice:deploy	1,376	11,731	393 (+1%)
SchnorrAccount:constructor	1,312	11,731	105 (-2%)
SchnorrAccount:entrypoint	2,304	11,731	432 (-1%)
Token:privately_mint_private_note	1,280	11,731	137 (-5%)
FPC:fee_entrypoint_public	1,344	11,731	28.3 (+3%)
Token:transfer	1,312	11,731	286 (-1%)
Benchmarking:create_note	1,344	11,731	103 (+1%)
SchnorrAccount:verify_private_authwit	1,280	11,731	27.7
Token:unshield	1,376	11,731	559
FPC:fee_entrypoint_private	1,376	11,731	763 (-1%)

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	54.3 (+1%)	8,139
FeeJuice:set_portal	12.3 (-4%)	2,362
Token:constructor	89.1 (+6%)	31,107
FPC:constructor	54.2 (+1%)	22,380
FeeJuice:mint_public	⚠️ 38.8 (-32%)	6,150
Token:mint_public	⚠️ 72.0 (+65%)	11,720
Token:assert_minter_and_mint	⚠️ 31.2 (-54%)	8,028
AuthRegistry:set_authorized	36.4 (-21%)	4,537
FPC:prepare_fee	241 (+1%)	8,812
Token:transfer_public	21.6 (-26%)	47,374
FPC:pay_refund	58.0	12,114
Benchmarking:increment_balance	966	7,450
Token:_increase_public_balance	40.2 (+4%)	8,960
FPC:pay_refund_with_shielded_rebate	68.4 (+2%)	12,663

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.156 (-2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.16	3.85 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113	0.109 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.6 (+1%)	17.8 (-1%)	31.1 (-3%)	59.8 (+2%)	112 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.111	0.104 (-1%)	0.101 (-3%)	0.103 (+2%)	0.101
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.4 (-1%)	25.8	43.7 (-2%)	82.6 (+1%)	161 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.110 (-2%)	0.104 (+1%)	0.106 (-2%)	0.102 (+1%)	0.101 (-3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.5	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132 (-1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.106	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |

[nventuro]

Why not include this in the constraning step? It's odd to have it outside

[sklppy88]

In my head they're two different logical purposes, these initial two steps are making sure that we are fetching from a "possible block number", and the other is making sure the header hint from this "possible block number" is correct. Does this seem fair to you ?

[nventuro]

Eh if the goal is to prevent an oracle failure might as well do assert(block_number < current_block_number) (which simply prevents future blocks due to the previous if), and leave the archive fetching internals up the constraining - it's a bit out of place as it has to do with how the constraning is done. But it's not ultimately very important, if anything this seems a symptom of proofs being tied to headers.

[nventuro]

I was referring to comments of this kind, which are rather useless. This is the famous let x = 5; // set x to 5.

[nventuro]

Eh if the goal is to prevent an oracle failure might as well do assert(block_number < current_block_number) (which simply prevents future blocks due to the previous if), and leave the archive fetching internals up the constraining - it's a bit out of place as it has to do with how the constraning is done. But it's not ultimately very important, if anything this seems a symptom of proofs being tied to headers.