-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Configuration for bot on various networks #8063
Merged
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
659fbcc
feat: Add max pending txs to bot
spalladino c442c12
Merge branch 'master' into palla/bot-max-pending-txs
PhilWindle ebde8b6
Bot flush setup transactions
PhilWindle 90bbc2c
More bot config
PhilWindle 2bd7982
Fixes
PhilWindle b724ef3
More logging
PhilWindle 5d1aab3
Merge branch 'master' into pw/more-config
PhilWindle d5b97b7
Fix
PhilWindle 9055e95
Merge remote-tracking branch 'origin/master' into pw/more-config
PhilWindle 011c010
Merge branch 'master' into pw/more-config
PhilWindle 5743e6d
Throw is invalid config
PhilWindle b6f45c7
Merge branch 'pw/more-config' of github.com:AztecProtocol/aztec-packa…
PhilWindle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
import { getSchnorrAccount } from '@aztec/accounts/schnorr'; | ||
import { type AccountWallet, BatchCall, createDebugLogger, createPXEClient } from '@aztec/aztec.js'; | ||
import { type FunctionCall, type PXE } from '@aztec/circuit-types'; | ||
import { type AztecNode, type FunctionCall, type PXE } from '@aztec/circuit-types'; | ||
import { Fr, deriveSigningKey } from '@aztec/circuits.js'; | ||
import { TokenContract } from '@aztec/noir-contracts.js/Token'; | ||
|
||
|
@@ -12,9 +12,11 @@ const MIN_BALANCE = 1e3; | |
|
||
export class BotFactory { | ||
private pxe: PXE; | ||
private node?: AztecNode; | ||
private log = createDebugLogger('aztec:bot'); | ||
|
||
constructor(private readonly config: BotConfig, dependencies: { pxe?: PXE } = {}) { | ||
constructor(private readonly config: BotConfig, dependencies: { pxe?: PXE; node?: AztecNode } = {}) { | ||
this.node = dependencies.node; | ||
if (!dependencies.pxe && !config.pxeUrl) { | ||
throw new Error(`Either a PXE client or a PXE URL must be provided`); | ||
} | ||
|
@@ -54,7 +56,14 @@ export class BotFactory { | |
return account.register(); | ||
} else { | ||
this.log.info(`Initializing account at ${account.getAddress().toString()}`); | ||
return account.waitSetup({ timeout: this.config.txMinedWaitSeconds }); | ||
const sentTx = account.deploy(); | ||
if (this.config.flushSetupTransactions && this.node) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd throw if flush is true but node is not set |
||
this.log.verbose('Flushing transactions'); | ||
await this.node.flushTxs(); | ||
} | ||
this.log.verbose('Waiting for account deployment to settle'); | ||
await sentTx.wait({ timeout: this.config.txMinedWaitSeconds }); | ||
return account.getWallet(); | ||
} | ||
} | ||
|
||
|
@@ -80,7 +89,13 @@ export class BotFactory { | |
return deploy.register(); | ||
} else { | ||
this.log.info(`Deploying token contract at ${address.toString()}`); | ||
return deploy.send(deployOpts).deployed({ timeout: this.config.txMinedWaitSeconds }); | ||
const sentTx = deploy.send(deployOpts); | ||
if (this.config.flushSetupTransactions && this.node) { | ||
this.log.verbose('Flushing transactions'); | ||
await this.node.flushTxs(); | ||
} | ||
this.log.verbose('Waiting for token setup to settle'); | ||
return sentTx.deployed({ timeout: this.config.txMinedWaitSeconds }); | ||
} | ||
} | ||
|
||
|
@@ -104,6 +119,12 @@ export class BotFactory { | |
this.log.info(`Skipping minting as ${sender.toString()} has enough tokens`); | ||
return; | ||
} | ||
await new BatchCall(token.wallet, calls).send().wait({ timeout: this.config.txMinedWaitSeconds }); | ||
const sentTx = new BatchCall(token.wallet, calls).send(); | ||
if (this.config.flushSetupTransactions && this.node) { | ||
this.log.verbose('Flushing transactions'); | ||
await this.node.flushTxs(); | ||
} | ||
this.log.verbose('Waiting for token mint to settle'); | ||
await sentTx.wait({ timeout: this.config.txMinedWaitSeconds }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't see the new
node
arg being used anywhere?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's just passed through, into the BotFactory constructor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right it's part of the dependencies obj, got it 👍