fix: Log public vm errors as warn in prover-agent

[spalladino]

And not the other way around. I need to relearn how booleans work.

[AztecBot]

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,761	1,564	715	774 (+2%)	777
proof_construction_time_sha256_30_ms	11,488	3,114	1,395 (+1%)	1,442	1,469
proof_construction_time_sha256_100_ms	44,276	11,943	5,528 (-1%)	5,525 (-2%)	5,805
proof_construction_time_poseidon_hash_ms	78.0 (-1%)	34.0	34.0	56.0 (-5%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,528	422	203	220 (-4%)	270 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,658	1,515	684 (+1%)	725	747

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,356	7,876	14,884
l1_rollup_calldata_gas	50,220	92,912	177,916
l1_rollup_execution_gas	842,880	1,576,468	3,361,528
l2_block_processing_time_in_ms	259 (+4%)	458 (+1%)	819 (+3%)
l2_block_building_time_in_ms	11,407	22,275 (-1%)	44,313
l2_block_rollup_simulation_time_in_ms	11,406	22,274 (-1%)	44,313
l2_block_public_tx_process_time_in_ms	9,672	20,452 (-1%)	42,478

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	2,967 (-2%)	4,082 (+3%)
node_database_size_in_bytes	12,644,432	16,678,992
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	97.3 (+5%)	377 (-1%)	21,735	44,860	N/A
private-kernel-inner	176 (-11%)	673	72,544	45,007	N/A
private-kernel-reset-tiny	310 (-1%)	682 (-1%)	65,593	44,846	N/A
private-kernel-tail	166 (-1%)	129 (-1%)	50,644	52,257	N/A
base-parity	5.53 (-1%)	N/A	160	96.0	N/A
root-parity	35.1	N/A	73,948	96.0	N/A
base-rollup	3,440 (-1%)	N/A	189,136	664	N/A
block-root-rollup	40.9	N/A	58,205	2,448	N/A
public-kernel-setup	83.8	N/A	105,085	71,222	N/A
public-kernel-app-logic	97.1	N/A	104,911	71,222	N/A
public-kernel-tail	856 (-1%)	N/A	390,582	16,414	N/A
private-kernel-reset-small	307	N/A	66,341	45,629	N/A
private-kernel-tail-to-public	1,330 (-1%)	589	455,400	1,825	N/A
public-kernel-teardown	83.3 (-1%)	N/A	105,349	71,222	N/A
merge-rollup	20.4	N/A	38,174	664	N/A
undefined	N/A	N/A	N/A	N/A	84,128

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	341 (-1%)
ContractInstanceDeployer:deploy	1,408	11,731	18.0 (-1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	401
FeeJuice:deploy	1,376	11,731	385 (-1%)
SchnorrAccount:constructor	1,312	11,731	72.8
SchnorrAccount:entrypoint	2,304	11,731	393
Token:privately_mint_private_note	1,280	11,731	99.9 (-2%)
FPC:fee_entrypoint_public	1,344	11,731	24.4 (-3%)
Token:transfer	1,312	11,731	221
Benchmarking:create_note	1,344	11,731	85.0 (-2%)
SchnorrAccount:verify_private_authwit	1,280	11,731	31.2 (+12%)
Token:unshield	1,376	11,731	527 (+1%)
FPC:fee_entrypoint_private	1,376	11,731	694

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	57.0	7,101
FeeJuice:set_portal	11.2 (+13%)	2,128
Token:constructor	85.9 (-1%)	25,285
FPC:constructor	54.3 (+1%)	17,853
FeeJuice:mint_public	38.4 (-2%)	5,415
Token:mint_public	43.3 (+2%)	10,101
Token:assert_minter_and_mint	65.7 (-2%)	6,844
AuthRegistry:set_authorized	36.7 (-21%)	3,969
FPC:prepare_fee	244 (+5%)	6,747
Token:transfer_public	22.3 (+8%)	38,126
FPC:pay_refund	48.2 (-13%)	9,398
Benchmarking:increment_balance	1,197 (-1%)	6,179
Token:_increase_public_balance	38.8 (-1%)	7,705
FPC:pay_refund_with_shielded_rebate	62.2 (-3%)	9,881

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.170 (+4%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.19 (+1%)	3.92	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.113 (+1%)	0.111	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.3	18.1 (-1%)	32.3 (+2%)	59.7	115 (+2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.108	0.105 (-1%)	0.104 (+2%)	0.103	0.103 (+1%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3	26.2 (+2%)	44.1 (-1%)	83.4 (+1%)	164 (+2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108	0.106 (+2%)	0.107	0.103	0.104 (+3%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.7	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	132	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	64,779	668,997

Transaction size based on fee payment method

| Metric | |
| - | |