refactor: Protogalaxy verifier matches prover 1 #8414

codygunton · 2024-09-06T04:12:44Z

This is doing some renaming, making types explicit, and simplifying the initialization used to produce an output accumulator.

AztecBot · 2024-09-09T20:41:25Z

Benchmark results

Metrics with a significant change:

protocol_circuit_simulation_time_in_ms (private-kernel-tail-to-public): 1,389 (+75%)
avm_simulation_time_ms (FeeJuice:_increase_public_balance): 160 (+237%)
avm_simulation_time_ms (Token:assert_minter_and_mint): 324 (-51%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,759	1,547	706 (-1%)	780 (+2%)	778
proof_construction_time_sha256_30_ms	11,459	3,049 (-1%)	1,361	1,408 (-2%)	1,443 (-1%)
proof_construction_time_sha256_100_ms	44,072	11,793	5,393 (-1%)	5,921 (+1%)	5,400 (+1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	34.0	58.0 (-2%)	88.0
proof_construction_time_poseidon_hash_30_ms	1,531	419	200	228 (-1%)	268 (+1%)
proof_construction_time_poseidon_hash_100_ms	5,642	1,502	670	717 (-1%)	741 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	4,420	7,940	14,948
l1_rollup_calldata_gas	50,476	93,260	178,436
l1_rollup_execution_gas	843,609	1,577,289	3,362,522
l2_block_processing_time_in_ms	257 (+1%)	452 (+2%)	813 (+1%)
l2_block_building_time_in_ms	11,777 (+2%)	22,502 (-1%)	45,502
l2_block_rollup_simulation_time_in_ms	11,777 (+2%)	22,502 (-1%)	45,502
l2_block_public_tx_process_time_in_ms	10,059 (+2%)	20,795 (-1%)	43,740

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	3,377	4,420 (+4%)
node_database_size_in_bytes	14,201,072	18,170,096
pxe_database_size_in_bytes	16,258	26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	input_size_in_bytes	output_size_in_bytes	proving_time_in_ms
private-kernel-init	75.2 (-2%)	374 (-1%)	21,027	44,933	N/A
private-kernel-inner	141 (+1%)	672 (-1%)	71,803	45,067	N/A
private-kernel-reset-tiny	290 (-1%)	664 (-1%)	64,669	44,922	N/A
private-kernel-tail	150 (-1%)	126	50,553	57,178	N/A
base-parity	5.53 (-1%)	N/A	160	96.0	N/A
root-parity	35.0	N/A	73,964	96.0	N/A
base-rollup	2,647 (+2%)	N/A	189,128	664	N/A
block-root-rollup	41.1 (-1%)	N/A	58,217	2,448	N/A
public-kernel-setup	83.8 (-1%)	N/A	114,433	79,670	N/A
public-kernel-app-logic	97.9	N/A	114,251	79,670	N/A
public-kernel-tail	844	N/A	487,098	16,414	N/A
private-kernel-reset-small	270	N/A	66,345	45,629	N/A
private-kernel-tail-to-public	⚠️ 1,389 (+75%)	589 (-2%)	449,631	1,825	N/A
public-kernel-teardown	83.5	N/A	114,697	79,670	N/A
merge-rollup	20.2 (-1%)	N/A	38,182	664	N/A
undefined	N/A	N/A	N/A	N/A	102,419 (+2%)

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms
ContractClassRegisterer:register	1,344	11,731	342
ContractInstanceDeployer:deploy	1,408	11,731	18.2 (+1%)
MultiCallEntrypoint:entrypoint	1,920	11,731	421
FeeJuice:deploy	1,376	11,731	394 (+1%)
SchnorrAccount:constructor	1,312	11,731	59.6 (-2%)
SchnorrAccount:entrypoint	2,336	11,731	367
FeeJuice:claim	1,344	11,731	36.1 (-3%)
Token:privately_mint_private_note	1,280	11,731	76.0 (+13%)
FPC:fee_entrypoint_public	1,344	11,731	23.9 (-6%)
Token:transfer	1,312	11,731	209 (-1%)
Benchmarking:create_note	1,344	11,731	74.6
SchnorrAccount:verify_private_authwit	1,280	11,731	26.4 (-1%)
Token:unshield	1,376	11,731	484 (-1%)
FPC:fee_entrypoint_private	1,376	11,731	645

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
FeeJuice:_increase_public_balance	⚠️ 160 (+237%)	1,322
FeeJuice:set_portal	8.79 (-12%)	1,332
Token:constructor	261 (-5%)	13,702
FPC:constructor	80.6 (+1%)	10,797
FeeJuice:check_balance	35.7 (-1%)	1,153
Token:mint_public	43.5 (-3%)	2,487
Token:assert_minter_and_mint	⚠️ 324 (-51%)	1,687
AuthRegistry:set_authorized	45.3 (+28%)	531
FPC:prepare_fee	105 (+2%)	1,822
Token:transfer_public	14.2 (-3%)	11,517
FPC:pay_refund	41.8 (+6%)	2,314
Benchmarking:increment_balance	1,236	1,573
Token:_increase_public_balance	38.4 (+1%)	1,299
FPC:pay_refund_with_shielded_rebate	49.6	2,314

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.261 (-11%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	2.21 (+1%)	3.82 (-1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.7	31.8	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.115 (+2%)	0.107	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	11.1 (-3%)	17.8 (+1%)	31.0 (-1%)	61.0 (+4%)	117 (+4%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.106 (-2%)	0.103 (+1%)	0.100	0.105 (+4%)	0.104 (+4%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	14.3	26.0 (+1%)	44.5	85.1 (+3%)	161
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	357	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.108 (-1%)	0.105 (+1%)	0.107	0.106 (+4%)	0.101 (-1%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	16.2 (+1%)	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	129	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.107	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	72,416	668,302

Transaction size based on fee payment method

| Metric | |
| - | |

codygunton · 2024-09-11T14:04:49Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_prover.hpp

@@ -45,10 +45,6 @@ template <class DeciderProvingKeys_> class ProtogalaxyProver_ {
        // TODO(https://github.com/AztecProtocol/barretenberg/issues/878)
        , commitment_key(keys_to_fold[1]->proving_key.commitment_key){};

-    // Returns the accumulator, which is the first element in DeciderProvingKeys. The accumulator is assumed to have the


Function is no longer in use.

codygunton · 2024-09-11T14:05:06Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

@@ -6,22 +6,23 @@
 namespace bb {

 template <class DeciderVerificationKeys>
-void ProtogalaxyVerifier_<DeciderVerificationKeys>::receive_and_finalise_key(const std::shared_ptr<DeciderVK>& keys,
-                                                                             const std::string& domain_separator)
+void ProtogalaxyVerifier_<DeciderVerificationKeys>::run_oink_verifier_on_one_incomplete_key(


Renaming function to match Prover.

codygunton · 2024-09-11T14:05:32Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

-    auto accumulator = get_accumulator();
-    auto deltas =
-        compute_round_challenge_pows(static_cast<size_t>(accumulator->verification_key->log_circuit_size), delta);
+    const FF delta = transcript->template get_challenge<FF>("delta");


Used explicit types and made things const.

codygunton · 2024-09-11T14:11:52Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

-        next_accumulator->verification_key->databus_propagation_data =
-            accumulator->verification_key->databus_propagation_data;
-    }
+    auto next_accumulator = std::make_shared<DeciderVK>();


Before: construct decider with a honk vk, which just default initializes and and std::moves the honk vk to be owned by the decider vk, then immediately overwrite that vk with something that looks like it should just be a copy constructor minus the honk vk being set.

After: just default initialize and set the pointer to a honk vk.

Note two things that do not work (basic Pg test fails; unsure why):

Just doing auto next_accumulator = std::make_shared<DeciderVK>(accumulator->verification_key); and no additional vk overwriting.

Just doing auto next_accumulator = std::make_shared<DeciderVK>(); then next_accumulator->verification_key = accumulator->verification_key;

WIll work to clarify in follow-on but this is an improvement as it is.

codygunton · 2024-09-11T14:12:44Z

barretenberg/cpp/src/barretenberg/stdlib_circuit_builders/databus.hpp

@@ -80,6 +80,16 @@ struct DatabusPropagationData {

    // Is this a kernel circuit (used to determine when databus consistency checks can be appended to a circuit in IVC)
    bool is_kernel = false;
+


I wanted to print these out, and I thought why not leave this function in place (it lets you write info on a DatabusPropagationData).

codygunton · 2024-09-11T14:14:00Z

barretenberg/cpp/src/barretenberg/ultra_honk/decider_verification_key.hpp

@@ -35,7 +35,7 @@ template <class Flavor, size_t NUM_ = 2> class DeciderVerificationKey_ {

    DeciderVerificationKey_() = default;
    DeciderVerificationKey_(std::shared_ptr<VerificationKey> vk)
-        : verification_key(std::move(vk))


This just is sub-microsecond optimization that we don't need and which hurts clarity here IMO.

…-prover

ledwards2225 · 2024-09-11T15:52:04Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

-    auto deltas =
-        compute_round_challenge_pows(static_cast<size_t>(accumulator->verification_key->log_circuit_size), delta);
+    const FF delta = transcript->template get_challenge<FF>("delta");
+    const std::shared_ptr<const DeciderVK>& accumulator = keys_to_fold[0]; // WORKTODO: move


ledwards2225 · 2024-09-11T16:00:23Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.cpp

-            accumulator->verification_key->databus_propagation_data;
-    }
+    auto next_accumulator = std::make_shared<DeciderVK>();
+    next_accumulator->verification_key = std::make_shared<VerificationKey>(*accumulator->verification_key);


Why not just next_accumulator->verification_key = accumulator->verification_key;? Oh I guess this exactly what you're saying doesnt work

I think the version you have is making a copy of VerificationKey, so the two things are definitely different. not totally clean why one would work and one wouldn't tho

ledwards2225 · 2024-09-11T16:03:54Z

barretenberg/cpp/src/barretenberg/protogalaxy/protogalaxy_verifier.hpp

-     * @brief Process the public data ϕ for the decider verification keys to be folded.
-     */
-    void receive_and_finalise_key(const std::shared_ptr<DeciderVK>&, const std::string&);
+    void run_oink_verifier_on_each_incomplete_key(const std::vector<FF>&);


thank god. every time I stepped through these two methods I felt like I was going insane

ledwards2225

LG, just a spare WORKTODO. Would definitely be nice to figure out why that vk shared ptr stuff is being funny. Probably indicative of some messiness that could bite us

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.55.0</summary> ## [0.55.0](aztec-package-v0.54.0...aztec-package-v0.55.0) (2024-09-13) ### Bug Fixes * Load prover node config from env ([#8525](#8525)) ([7065962](7065962)) ### Miscellaneous * Remove unneeded propose and da oracle ([#8474](#8474)) ([274a6b7](274a6b7)) </details> <details><summary>barretenberg.js: 0.55.0</summary> ## [0.55.0](barretenberg.js-v0.54.0...barretenberg.js-v0.55.0) (2024-09-13) ### Features * New test programs for wasm benchmarking ([#8389](#8389)) ([0b46e96](0b46e96)) </details> <details><summary>aztec-packages: 0.55.0</summary> ## [0.55.0](aztec-packages-v0.54.0...aztec-packages-v0.55.0) (2024-09-13) ### ⚠ BREAKING CHANGES * Add Not instruction in brillig ([#8488](#8488)) * refactor NoteGetterOptions::select API ([#8504](#8504)) * **avm:** variants for CAST/NOT opcode ([#8497](#8497)) * **avm:** variants for REVERT opcode ([#8487](#8487)) ### Features * (bb) remove redundant constraints on field/group elements when using goblin plonk ([#8409](#8409)) ([12a093d](12a093d)) * Add `Module::structs` (noir-lang/noir#6017) ([cb20e07](cb20e07)) * Add `TypedExpr::get_type` (noir-lang/noir#5992) ([875cfe6](875cfe6)) * Add assertions for ACVM `FunctionInput` `bit_size` (noir-lang/noir#5864) ([20d7576](20d7576)) * Add Not instruction in brillig ([#8488](#8488)) ([ceda361](ceda361)) * Add timeouts for request / response stream connections ([#8434](#8434)) ([190c27f](190c27f)) * **avm:** Parallelize polynomial alloc and set ([#8520](#8520)) ([7e73531](7e73531)) * **avm:** Variants for CAST/NOT opcode ([#8497](#8497)) ([bc609fa](bc609fa)) * **avm:** Variants for REVERT opcode ([#8487](#8487)) ([a0c8915](a0c8915)) * **bb:** Iterative constexpr_for ([#8502](#8502)) ([02c3330](02c3330)) * Better error message for misplaced doc comments (noir-lang/noir#5990) ([875cfe6](875cfe6)) * Change the layout of arrays and vectors to be a single pointer ([#8448](#8448)) ([3ad624c](3ad624c)) * Checking finalized sizes + a test of two folding verifiers ([#8503](#8503)) ([d9e3f4d](d9e3f4d)) * Extract brillig slice ops to reusable procedures (noir-lang/noir#6002) ([20d7576](20d7576)) * Format trait impl functions (noir-lang/noir#6016) ([cb20e07](cb20e07)) * Impl Hash and Eq on more comptime types (noir-lang/noir#6022) ([cb20e07](cb20e07)) * Implement LSP code action "Implement missing members" (noir-lang/noir#6020) ([cb20e07](cb20e07)) * Let `has_named_attribute` work for built-in attributes (noir-lang/noir#6024) ([cb20e07](cb20e07)) * LSP completion function detail (noir-lang/noir#5993) ([875cfe6](875cfe6)) * Native world state ([#7516](#7516)) ([c1aa6f7](c1aa6f7)) * New test programs for wasm benchmarking ([#8389](#8389)) ([0b46e96](0b46e96)) * Output timestamps in prover-stats raw logs ([#8476](#8476)) ([aa67a14](aa67a14)) * Rate limit peers in request response p2p interactions ([#8498](#8498)) ([00146fa](00146fa)) * Refactor NoteGetterOptions::select API ([#8504](#8504)) ([e527992](e527992)) * Sync from aztec-packages (noir-lang/noir#5971) ([875cfe6](875cfe6)) * Sync from aztec-packages (noir-lang/noir#6001) ([20d7576](20d7576)) * Use Zac's quicksort algorithm in stdlib sorting (noir-lang/noir#5940) ([20d7576](20d7576)) * Validators ensure transactions live in their p2p pool before attesting ([#8410](#8410)) ([bce1eea](bce1eea)) * Verification key stuff ([#8431](#8431)) ([11dc8ff](11dc8ff)) ### Bug Fixes * Correctly print string tokens (noir-lang/noir#6021) ([cb20e07](cb20e07)) * Enable verifier when deploying the networks ([#8500](#8500)) ([f6d31f1](f6d31f1)) * Error when comptime types are used in runtime code (noir-lang/noir#5987) ([875cfe6](875cfe6)) * Error when mutating comptime variables in non-comptime code (noir-lang/noir#6003) ([20d7576](20d7576)) * Fix some mistakes in arithmetic generics docs (noir-lang/noir#5999) ([20d7576](20d7576)) * Fix using lazily elaborated comptime globals (noir-lang/noir#5995) ([20d7576](20d7576)) * Help link was outdated (noir-lang/noir#6004) ([20d7576](20d7576)) * Load prover node config from env ([#8525](#8525)) ([7065962](7065962)) * Remove claim_public from fee juice ([#8337](#8337)) ([dca74ae](dca74ae)) * Try to move constant terms to one side for arithmetic generics (noir-lang/noir#6008) ([cb20e07](cb20e07)) * Use module name as line after which we'll insert auto-import (noir-lang/noir#6025) ([cb20e07](cb20e07)) ### Miscellaneous * Add some `pub use` and remove unused imports ([#8521](#8521)) ([8bd0755](8bd0755)) * **bb:** Fix mac build ([#8505](#8505)) ([32fd347](32fd347)), closes [#8499](#8499) * **bb:** Fix mac build ([#8522](#8522)) ([986e703](986e703)) * **ci:** Fix bb publishing ([#8486](#8486)) ([c210c36](c210c36)) * Fix a load of warnings in aztec-nr ([#8501](#8501)) ([35dc1e1](35dc1e1)) * Protogalaxy verifier matches prover 1 ([#8414](#8414)) ([5a76ec6](5a76ec6)) * Remove RC tracking in mem2reg (noir-lang/noir#6019) ([cb20e07](cb20e07)) * Remove unneeded propose and da oracle ([#8474](#8474)) ([274a6b7](274a6b7)) * Replace relative paths to noir-protocol-circuits ([b179c6b](b179c6b)) * Replace relative paths to noir-protocol-circuits ([1c042be](1c042be)) * Replace relative paths to noir-protocol-circuits ([1c8409f](1c8409f)) * Run mac builds on master ([#8519](#8519)) ([c458a79](c458a79)) * Single install script for cargo-binstall (noir-lang/noir#5998) ([20d7576](20d7576)) * Use uint32_t instead of size_t for databus data ([#8479](#8479)) ([79995c8](79995c8)) </details> <details><summary>barretenberg: 0.55.0</summary> ## [0.55.0](barretenberg-v0.54.0...barretenberg-v0.55.0) (2024-09-13) ### ⚠ BREAKING CHANGES * Add Not instruction in brillig ([#8488](#8488)) * **avm:** variants for CAST/NOT opcode ([#8497](#8497)) * **avm:** variants for REVERT opcode ([#8487](#8487)) ### Features * (bb) remove redundant constraints on field/group elements when using goblin plonk ([#8409](#8409)) ([12a093d](12a093d)) * Add Not instruction in brillig ([#8488](#8488)) ([ceda361](ceda361)) * **avm:** Parallelize polynomial alloc and set ([#8520](#8520)) ([7e73531](7e73531)) * **avm:** Variants for CAST/NOT opcode ([#8497](#8497)) ([bc609fa](bc609fa)) * **avm:** Variants for REVERT opcode ([#8487](#8487)) ([a0c8915](a0c8915)) * **bb:** Iterative constexpr_for ([#8502](#8502)) ([02c3330](02c3330)) * Checking finalized sizes + a test of two folding verifiers ([#8503](#8503)) ([d9e3f4d](d9e3f4d)) * Native world state ([#7516](#7516)) ([c1aa6f7](c1aa6f7)) * New test programs for wasm benchmarking ([#8389](#8389)) ([0b46e96](0b46e96)) * Verification key stuff ([#8431](#8431)) ([11dc8ff](11dc8ff)) ### Miscellaneous * **bb:** Fix mac build ([#8505](#8505)) ([32fd347](32fd347)), closes [#8499](#8499) * **bb:** Fix mac build ([#8522](#8522)) ([986e703](986e703)) * Protogalaxy verifier matches prover 1 ([#8414](#8414)) ([5a76ec6](5a76ec6)) * Use uint32_t instead of size_t for databus data ([#8479](#8479)) ([79995c8](79995c8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.55.0</summary> ## [0.55.0](AztecProtocol/aztec-packages@aztec-package-v0.54.0...aztec-package-v0.55.0) (2024-09-13) ### Bug Fixes * Load prover node config from env ([#8525](AztecProtocol/aztec-packages#8525)) ([7065962](AztecProtocol/aztec-packages@7065962)) ### Miscellaneous * Remove unneeded propose and da oracle ([#8474](AztecProtocol/aztec-packages#8474)) ([274a6b7](AztecProtocol/aztec-packages@274a6b7)) </details> <details><summary>barretenberg.js: 0.55.0</summary> ## [0.55.0](AztecProtocol/aztec-packages@barretenberg.js-v0.54.0...barretenberg.js-v0.55.0) (2024-09-13) ### Features * New test programs for wasm benchmarking ([#8389](AztecProtocol/aztec-packages#8389)) ([0b46e96](AztecProtocol/aztec-packages@0b46e96)) </details> <details><summary>aztec-packages: 0.55.0</summary> ## [0.55.0](AztecProtocol/aztec-packages@aztec-packages-v0.54.0...aztec-packages-v0.55.0) (2024-09-13) ### ⚠ BREAKING CHANGES * Add Not instruction in brillig ([#8488](AztecProtocol/aztec-packages#8488)) * refactor NoteGetterOptions::select API ([#8504](AztecProtocol/aztec-packages#8504)) * **avm:** variants for CAST/NOT opcode ([#8497](AztecProtocol/aztec-packages#8497)) * **avm:** variants for REVERT opcode ([#8487](AztecProtocol/aztec-packages#8487)) ### Features * (bb) remove redundant constraints on field/group elements when using goblin plonk ([#8409](AztecProtocol/aztec-packages#8409)) ([12a093d](AztecProtocol/aztec-packages@12a093d)) * Add `Module::structs` (noir-lang/noir#6017) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * Add `TypedExpr::get_type` (noir-lang/noir#5992) ([875cfe6](AztecProtocol/aztec-packages@875cfe6)) * Add assertions for ACVM `FunctionInput` `bit_size` (noir-lang/noir#5864) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Add Not instruction in brillig ([#8488](AztecProtocol/aztec-packages#8488)) ([ceda361](AztecProtocol/aztec-packages@ceda361)) * Add timeouts for request / response stream connections ([#8434](AztecProtocol/aztec-packages#8434)) ([190c27f](AztecProtocol/aztec-packages@190c27f)) * **avm:** Parallelize polynomial alloc and set ([#8520](AztecProtocol/aztec-packages#8520)) ([7e73531](AztecProtocol/aztec-packages@7e73531)) * **avm:** Variants for CAST/NOT opcode ([#8497](AztecProtocol/aztec-packages#8497)) ([bc609fa](AztecProtocol/aztec-packages@bc609fa)) * **avm:** Variants for REVERT opcode ([#8487](AztecProtocol/aztec-packages#8487)) ([a0c8915](AztecProtocol/aztec-packages@a0c8915)) * **bb:** Iterative constexpr_for ([#8502](AztecProtocol/aztec-packages#8502)) ([02c3330](AztecProtocol/aztec-packages@02c3330)) * Better error message for misplaced doc comments (noir-lang/noir#5990) ([875cfe6](AztecProtocol/aztec-packages@875cfe6)) * Change the layout of arrays and vectors to be a single pointer ([#8448](AztecProtocol/aztec-packages#8448)) ([3ad624c](AztecProtocol/aztec-packages@3ad624c)) * Checking finalized sizes + a test of two folding verifiers ([#8503](AztecProtocol/aztec-packages#8503)) ([d9e3f4d](AztecProtocol/aztec-packages@d9e3f4d)) * Extract brillig slice ops to reusable procedures (noir-lang/noir#6002) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Format trait impl functions (noir-lang/noir#6016) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * Impl Hash and Eq on more comptime types (noir-lang/noir#6022) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * Implement LSP code action "Implement missing members" (noir-lang/noir#6020) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * Let `has_named_attribute` work for built-in attributes (noir-lang/noir#6024) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * LSP completion function detail (noir-lang/noir#5993) ([875cfe6](AztecProtocol/aztec-packages@875cfe6)) * Native world state ([#7516](AztecProtocol/aztec-packages#7516)) ([c1aa6f7](AztecProtocol/aztec-packages@c1aa6f7)) * New test programs for wasm benchmarking ([#8389](AztecProtocol/aztec-packages#8389)) ([0b46e96](AztecProtocol/aztec-packages@0b46e96)) * Output timestamps in prover-stats raw logs ([#8476](AztecProtocol/aztec-packages#8476)) ([aa67a14](AztecProtocol/aztec-packages@aa67a14)) * Rate limit peers in request response p2p interactions ([#8498](AztecProtocol/aztec-packages#8498)) ([00146fa](AztecProtocol/aztec-packages@00146fa)) * Refactor NoteGetterOptions::select API ([#8504](AztecProtocol/aztec-packages#8504)) ([e527992](AztecProtocol/aztec-packages@e527992)) * Sync from aztec-packages (noir-lang/noir#5971) ([875cfe6](AztecProtocol/aztec-packages@875cfe6)) * Sync from aztec-packages (noir-lang/noir#6001) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Use Zac's quicksort algorithm in stdlib sorting (noir-lang/noir#5940) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Validators ensure transactions live in their p2p pool before attesting ([#8410](AztecProtocol/aztec-packages#8410)) ([bce1eea](AztecProtocol/aztec-packages@bce1eea)) * Verification key stuff ([#8431](AztecProtocol/aztec-packages#8431)) ([11dc8ff](AztecProtocol/aztec-packages@11dc8ff)) ### Bug Fixes * Correctly print string tokens (noir-lang/noir#6021) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * Enable verifier when deploying the networks ([#8500](AztecProtocol/aztec-packages#8500)) ([f6d31f1](AztecProtocol/aztec-packages@f6d31f1)) * Error when comptime types are used in runtime code (noir-lang/noir#5987) ([875cfe6](AztecProtocol/aztec-packages@875cfe6)) * Error when mutating comptime variables in non-comptime code (noir-lang/noir#6003) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Fix some mistakes in arithmetic generics docs (noir-lang/noir#5999) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Fix using lazily elaborated comptime globals (noir-lang/noir#5995) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Help link was outdated (noir-lang/noir#6004) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Load prover node config from env ([#8525](AztecProtocol/aztec-packages#8525)) ([7065962](AztecProtocol/aztec-packages@7065962)) * Remove claim_public from fee juice ([#8337](AztecProtocol/aztec-packages#8337)) ([dca74ae](AztecProtocol/aztec-packages@dca74ae)) * Try to move constant terms to one side for arithmetic generics (noir-lang/noir#6008) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * Use module name as line after which we'll insert auto-import (noir-lang/noir#6025) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) ### Miscellaneous * Add some `pub use` and remove unused imports ([#8521](AztecProtocol/aztec-packages#8521)) ([8bd0755](AztecProtocol/aztec-packages@8bd0755)) * **bb:** Fix mac build ([#8505](AztecProtocol/aztec-packages#8505)) ([32fd347](AztecProtocol/aztec-packages@32fd347)), closes [#8499](AztecProtocol/aztec-packages#8499) * **bb:** Fix mac build ([#8522](AztecProtocol/aztec-packages#8522)) ([986e703](AztecProtocol/aztec-packages@986e703)) * **ci:** Fix bb publishing ([#8486](AztecProtocol/aztec-packages#8486)) ([c210c36](AztecProtocol/aztec-packages@c210c36)) * Fix a load of warnings in aztec-nr ([#8501](AztecProtocol/aztec-packages#8501)) ([35dc1e1](AztecProtocol/aztec-packages@35dc1e1)) * Protogalaxy verifier matches prover 1 ([#8414](AztecProtocol/aztec-packages#8414)) ([5a76ec6](AztecProtocol/aztec-packages@5a76ec6)) * Remove RC tracking in mem2reg (noir-lang/noir#6019) ([cb20e07](AztecProtocol/aztec-packages@cb20e07)) * Remove unneeded propose and da oracle ([#8474](AztecProtocol/aztec-packages#8474)) ([274a6b7](AztecProtocol/aztec-packages@274a6b7)) * Replace relative paths to noir-protocol-circuits ([b179c6b](AztecProtocol/aztec-packages@b179c6b)) * Replace relative paths to noir-protocol-circuits ([1c042be](AztecProtocol/aztec-packages@1c042be)) * Replace relative paths to noir-protocol-circuits ([1c8409f](AztecProtocol/aztec-packages@1c8409f)) * Run mac builds on master ([#8519](AztecProtocol/aztec-packages#8519)) ([c458a79](AztecProtocol/aztec-packages@c458a79)) * Single install script for cargo-binstall (noir-lang/noir#5998) ([20d7576](AztecProtocol/aztec-packages@20d7576)) * Use uint32_t instead of size_t for databus data ([#8479](AztecProtocol/aztec-packages#8479)) ([79995c8](AztecProtocol/aztec-packages@79995c8)) </details> <details><summary>barretenberg: 0.55.0</summary> ## [0.55.0](AztecProtocol/aztec-packages@barretenberg-v0.54.0...barretenberg-v0.55.0) (2024-09-13) ### ⚠ BREAKING CHANGES * Add Not instruction in brillig ([#8488](AztecProtocol/aztec-packages#8488)) * **avm:** variants for CAST/NOT opcode ([#8497](AztecProtocol/aztec-packages#8497)) * **avm:** variants for REVERT opcode ([#8487](AztecProtocol/aztec-packages#8487)) ### Features * (bb) remove redundant constraints on field/group elements when using goblin plonk ([#8409](AztecProtocol/aztec-packages#8409)) ([12a093d](AztecProtocol/aztec-packages@12a093d)) * Add Not instruction in brillig ([#8488](AztecProtocol/aztec-packages#8488)) ([ceda361](AztecProtocol/aztec-packages@ceda361)) * **avm:** Parallelize polynomial alloc and set ([#8520](AztecProtocol/aztec-packages#8520)) ([7e73531](AztecProtocol/aztec-packages@7e73531)) * **avm:** Variants for CAST/NOT opcode ([#8497](AztecProtocol/aztec-packages#8497)) ([bc609fa](AztecProtocol/aztec-packages@bc609fa)) * **avm:** Variants for REVERT opcode ([#8487](AztecProtocol/aztec-packages#8487)) ([a0c8915](AztecProtocol/aztec-packages@a0c8915)) * **bb:** Iterative constexpr_for ([#8502](AztecProtocol/aztec-packages#8502)) ([02c3330](AztecProtocol/aztec-packages@02c3330)) * Checking finalized sizes + a test of two folding verifiers ([#8503](AztecProtocol/aztec-packages#8503)) ([d9e3f4d](AztecProtocol/aztec-packages@d9e3f4d)) * Native world state ([#7516](AztecProtocol/aztec-packages#7516)) ([c1aa6f7](AztecProtocol/aztec-packages@c1aa6f7)) * New test programs for wasm benchmarking ([#8389](AztecProtocol/aztec-packages#8389)) ([0b46e96](AztecProtocol/aztec-packages@0b46e96)) * Verification key stuff ([#8431](AztecProtocol/aztec-packages#8431)) ([11dc8ff](AztecProtocol/aztec-packages@11dc8ff)) ### Miscellaneous * **bb:** Fix mac build ([#8505](AztecProtocol/aztec-packages#8505)) ([32fd347](AztecProtocol/aztec-packages@32fd347)), closes [#8499](AztecProtocol/aztec-packages#8499) * **bb:** Fix mac build ([#8522](AztecProtocol/aztec-packages#8522)) ([986e703](AztecProtocol/aztec-packages@986e703)) * Protogalaxy verifier matches prover 1 ([#8414](AztecProtocol/aztec-packages#8414)) ([5a76ec6](AztecProtocol/aztec-packages@5a76ec6)) * Use uint32_t instead of size_t for databus data ([#8479](AztecProtocol/aztec-packages#8479)) ([79995c8](AztecProtocol/aztec-packages@79995c8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

codygunton self-assigned this Sep 6, 2024

codygunton force-pushed the cg/pg-verifier-like-prover branch from f5ddef7 to 8351271 Compare September 9, 2024 16:36

codygunton added 4 commits September 9, 2024 17:09

isolate bad test

830af4b

Ditch get_accumulator functions

16e9409

Rename

15d1b19

Rename and constify

ad26d48

codygunton marked this pull request as ready for review September 9, 2024 18:11

codygunton force-pushed the cg/pg-verifier-like-prover branch from 8351271 to ad26d48 Compare September 9, 2024 18:11

codygunton added 4 commits September 9, 2024 19:06

Add printing to databus propagation data

4525987

remove print

3150a62

Working to detangle vk ownership

565b6e4

No vk field manipulation

cb17897

AztecProtocol deleted a comment from AztecBot Sep 9, 2024

codygunton added 2 commits September 10, 2024 14:42

Merge branch 'master' into cg/pg-verifier-like-prover

557cb89

Don't disable VM

22bf3c7

codygunton force-pushed the cg/pg-verifier-like-prover branch from 9542f85 to 22bf3c7 Compare September 10, 2024 21:51

Revert earthfile change

e1f005e

codygunton changed the title ~~refactor: Clean up Protogalaxy verifier to mirror prover~~ refactor: Clean up Protogalaxy verifier to mirror prover 1 Sep 11, 2024

codygunton changed the title ~~refactor: Clean up Protogalaxy verifier to mirror prover 1~~ refactor: Protogalaxy verifier matches prover 1 Sep 11, 2024

codygunton commented Sep 11, 2024

View reviewed changes

Merge remote-tracking branch 'origin/master' into cg/pg-verifier-like…

c20674d

…-prover

ledwards2225 reviewed Sep 11, 2024

View reviewed changes

ledwards2225 approved these changes Sep 11, 2024

View reviewed changes

codygunton merged commit 5a76ec6 into master Sep 11, 2024
36 checks passed

codygunton deleted the cg/pg-verifier-like-prover branch September 11, 2024 16:21

AztecBot mentioned this pull request Sep 11, 2024

chore(master): Release 0.55.0 #8478

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: Protogalaxy verifier matches prover 1 #8414

refactor: Protogalaxy verifier matches prover 1 #8414

codygunton commented Sep 6, 2024 •

edited

Loading

AztecBot commented Sep 9, 2024 •

edited

Loading

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

codygunton Sep 11, 2024

codygunton Sep 11, 2024

codygunton Sep 11, 2024

codygunton Sep 11, 2024 •

edited

Loading

codygunton Sep 11, 2024

codygunton Sep 11, 2024

ledwards2225 Sep 11, 2024

ledwards2225 Sep 11, 2024 •

edited

Loading

ledwards2225 Sep 11, 2024

ledwards2225 Sep 11, 2024

ledwards2225 left a comment

		@@ -80,6 +80,16 @@ struct DatabusPropagationData {

		// Is this a kernel circuit (used to determine when databus consistency checks can be appended to a circuit in IVC)
		bool is_kernel = false;

refactor: Protogalaxy verifier matches prover 1 #8414

refactor: Protogalaxy verifier matches prover 1 #8414

Conversation

codygunton commented Sep 6, 2024 • edited Loading

AztecBot commented Sep 9, 2024 • edited Loading

Benchmark results

Proof generation

L2 block published to L1

L2 chain processing

Circuits stats

AVM Simulation

Public DB Access

Tree insertion stats

Miscellaneous

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codygunton Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ledwards2225 Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ledwards2225 left a comment

Choose a reason for hiding this comment

codygunton commented Sep 6, 2024 •

edited

Loading

AztecBot commented Sep 9, 2024 •

edited

Loading

codygunton Sep 11, 2024 •

edited

Loading

ledwards2225 Sep 11, 2024 •

edited

Loading