Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(avm): full proving kernel fix #8468

Merged
merged 1 commit into from
Sep 10, 2024
Merged

fix(avm): full proving kernel fix #8468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions barretenberg/cpp/src/barretenberg/vm/avm/tests/execution.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2113,9 +2113,9 @@ TEST_F(AvmExecutionTests, kernelOutputHashExistsOpcodes)
trace.begin(), trace.end(), [&](Row r) { return r.main_clk == START_NULLIFIER_EXISTS_OFFSET; });
EXPECT_EQ(nullifier_out_row->main_kernel_value_out, 1); // value
// TODO(#8287)
// EXPECT_EQ(nullifier_out_row->main_kernel_side_effect_out, 1);
EXPECT_EQ(nullifier_out_row->main_kernel_side_effect_out, 0);
EXPECT_EQ(nullifier_out_row->main_kernel_metadata_out, 1); // exists
feed_output(START_NULLIFIER_EXISTS_OFFSET, 1, 1, 1);
feed_output(START_NULLIFIER_EXISTS_OFFSET, 1, 0, 1);

// CHECK L1TOL2MSGEXISTS
auto l1_to_l2_row =
Expand All @@ -2128,9 +2128,9 @@ TEST_F(AvmExecutionTests, kernelOutputHashExistsOpcodes)
trace.begin(), trace.end(), [&](Row r) { return r.main_clk == START_L1_TO_L2_MSG_EXISTS_WRITE_OFFSET; });
EXPECT_EQ(msg_out_row->main_kernel_value_out, 1); // value
// TODO(#8287)
// EXPECT_EQ(msg_out_row->main_kernel_side_effect_out, 2);
EXPECT_EQ(msg_out_row->main_kernel_side_effect_out, 0);
EXPECT_EQ(msg_out_row->main_kernel_metadata_out, 1); // exists
feed_output(START_L1_TO_L2_MSG_EXISTS_WRITE_OFFSET, 1, 2, 1);
feed_output(START_L1_TO_L2_MSG_EXISTS_WRITE_OFFSET, 1, 0, 1);

validate_trace(std::move(trace), public_inputs);
}
Expand Down
Loading