-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Integrate databus in the private kernels #9028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirasistant
changed the title
feat: Integrate databus in the private kernels (WIP)
feat: Integrate databus in the private kernels [WIP]
Oct 4, 2024
sirasistant
added
e2e-all
CI: Enables this CI job.
bench-all
CI: Enables this CI job.
labels
Oct 4, 2024
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
…-packages into arv/databus_protocol
sirasistant
changed the title
feat: Integrate databus in the private kernels [WIP]
feat: Integrate databus in the private kernels
Oct 8, 2024
LeilaWang
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates the databus in the private kernels. We do this by annotating with call_data(0) for previous kernel public inputs and call_data(1) for app public inputs. Kernels and apps expose their own public inputs as return_data except the tail kernel who does it via the traditional public inputs mechanism for the tube.