Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Integrate databus in the private kernels #9028

Merged
merged 21 commits into from
Oct 8, 2024

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Oct 4, 2024

Integrates the databus in the private kernels. We do this by annotating with call_data(0) for previous kernel public inputs and call_data(1) for app public inputs. Kernels and apps expose their own public inputs as return_data except the tail kernel who does it via the traditional public inputs mechanism for the tube.

@sirasistant sirasistant marked this pull request as ready for review October 4, 2024 14:23
@sirasistant sirasistant changed the title feat: Integrate databus in the private kernels (WIP) feat: Integrate databus in the private kernels [WIP] Oct 4, 2024
@sirasistant sirasistant added e2e-all CI: Enables this CI job. bench-all CI: Enables this CI job. labels Oct 4, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Changes to circuit sizes

Generated at commit: aca9fec1e1e1fdb10876b3e0deeb05fcd004b654, compared to commit: 97e4b9b2e0d37575b6b5e4c7a22f85b60d1f418b

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init -8 ✅ -0.03% +1,628 ❌ +5.39%
private_kernel_reset_4_4_4_4_4_4_4_4_1 -4 ✅ -0.01% +843 ❌ +1.15%
private_kernel_reset -4 ✅ -0.00% -2,422 ✅ -0.52%
private_kernel_inner -19 ✅ -0.04% -2,982 ✅ -5.43%
private_kernel_tail_to_public -5 ✅ -0.02% -2,332 ✅ -5.58%
private_kernel_tail -3 ✅ -0.06% -1,904 ✅ -17.42%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_init 24,893 (-8) -0.03% 31,835 (+1,628) +5.39%
private_kernel_reset_4_4_4_4_4_4_4_4_1 34,895 (-4) -0.01% 74,459 (+843) +1.15%
private_kernel_reset 91,931 (-4) -0.00% 467,711 (-2,422) -0.52%
private_kernel_inner 43,932 (-19) -0.04% 51,905 (-2,982) -5.43%
private_kernel_tail_to_public 29,826 (-5) -0.02% 39,492 (-2,332) -5.58%
private_kernel_tail 4,742 (-3) -0.06% 9,023 (-1,904) -17.42%

@sirasistant sirasistant changed the title feat: Integrate databus in the private kernels [WIP] feat: Integrate databus in the private kernels Oct 8, 2024
Copy link
Contributor

@LeilaWang LeilaWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! 🎉

@sirasistant sirasistant merged commit 1798b1c into master Oct 8, 2024
98 checks passed
@sirasistant sirasistant deleted the arv/databus_protocol branch October 8, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bench-all CI: Enables this CI job. e2e-all CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants