Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make gate counting functions less confusing and avoid estimations #9046

Merged
merged 17 commits into from
Oct 9, 2024
Merged

fix: make gate counting functions less confusing and avoid estimations #9046

merged 17 commits into from
Oct 9, 2024

Commits on Oct 7, 2024

  1. set ensure_non_zero flag to be true in a few places and change the fu… 

    …nction
    @lucasxia01
    lucasxia01 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5829dd6 View commit details
    Browse the repository at this point in the history

  2. oops, forgot a call

    @lucasxia01
    lucasxia01 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    75052af View commit details
    Browse the repository at this point in the history

  3. change function names to be accurate: get_estimated instead of just get

    @lucasxia01
    lucasxia01 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    639a4b8 View commit details
    Browse the repository at this point in the history

  4. rename things and fix plonk maybe?

    @lucasxia01
    lucasxia01 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    62334ee View commit details
    Browse the repository at this point in the history

  5. try to purge using estimated gate count from bb binary and bb.js

    @lucasxia01
    lucasxia01 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    04f953b View commit details
    Browse the repository at this point in the history

  6. updating hbs files for avm

    @lucasxia01
    lucasxia01 committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e3f5beb View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. rename acir composer create circuit

    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    8d0d7fd View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into lx/fix-finalize-cir… 

    …cuit-calls
    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    d0fd343 View commit details
    Browse the repository at this point in the history

  3. remove initialize srs size computation for honk

    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    ef8e8b5 View commit details
    Browse the repository at this point in the history

  4. undo circuit_size -> dyadic_circuit_size

    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6a923f5 View commit details
    Browse the repository at this point in the history

  5. undo some changes to smt function names

    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    6258541 View commit details
    Browse the repository at this point in the history

  6. add TODO for gate counting difference

    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    374dd95 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into lx/fix-finalize-circuit-calls

    @lucasxia01
    lucasxia01 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    4e2053f View commit details
    Browse the repository at this point in the history

  8. Merge branch 'lx/fix-finalize-circuit-calls' of github.com:AztecProto… 

    …col/aztec-packages into lx/fix-finalize-circuit-calls
    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    b4a59b2 View commit details
    Browse the repository at this point in the history

  9. cleanup and resolve comments

    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    7c2064b View commit details
    Browse the repository at this point in the history

  10. forgot to commit a change whoops

    @lucasxia01
    lucasxia01 committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    37392f1 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'master' into lx/fix-finalize-circuit-calls

    @lucasxia01
    lucasxia01 authored Oct 8, 2024
    Configuration menu
    Copy the full SHA
    298810c View commit details
    Browse the repository at this point in the history