chore!: remove pedersen hash and commitment opcodes #9107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vezenovm
approved these changes
Oct 9, 2024
TomAFrench
changed the title
|
Holding off on merging this until #8989 is ready to go in. |
Changes to public function bytecode sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
dbanks12
approved these changes
Oct 9, 2024
|
@TomAFrench should this be good to go now that #8989 is merged? |
|
This isn't blocked on anything but I'm getting a strange noir compiler panic where an EmbeddedCurvePoint isn't being being flattened properly due to types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pedersen hash opcode as it's not currently possible to emit these from noir code.