This repository has been archived by the owner on Mar 16, 2023. It is now read-only.
Fix issues in sdk #469
Merged
Fix issues in sdk #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeandrews
approved these changes
Feb 6, 2020
|
@LeilaWang just pinging about lint issue when you have a second. |
|
🎉 This PR is included in version 1.19.0 🎉 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.5.0 🎉 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.7.0 🎉 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.17.0 🎉 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.18.0 🎉 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.4.0 🎉 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.2 🎉 Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.1.4 🎉 Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple minor issues in the sdk
balanceOfLinkedTokenreturns an overflown number #468 )This PR also introduces a mechanism to modify indexedDB and local storage if necessary in the future versions of the sdk.
Testing instructions
Tests for indexedDB migrations are in
packages/extension/src/background/tasks/__tests__/migrateIndexedDB.spec.jsTests for upgradable local storage data are integrated into existing tests in
packages/extension/src/background/services/NoteService/__tests__/Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)