Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate recursive aggregation object code #1044

Closed
lucasxia01 opened this issue Jul 3, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#7466
Closed

Reinstate recursive aggregation object code #1044

lucasxia01 opened this issue Jul 3, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#7466
Assignees
@lucasxia01

Comments

@lucasxia01
Copy link
Contributor

During the rollup integration process, we commented out and removed recursive aggregation code, so we should reinstate it.
@lucasxia01 lucasxia01 self-assigned this Jul 3, 2024
@lucasxia01 lucasxia01 mentioned this issue Jul 3, 2024
Merged
@lucasxia01 lucasxia01 mentioned this issue Jul 12, 2024
Merged
lucasxia01 added a commit to AztecProtocol/aztec-packages that referenced this issue Jul 25, 2024
@lucasxia01
feat: adding aggregation to honk and rollup (#7466)
2633aa9 
Closes AztecProtocol/barretenberg#1044.

Re-enables (most) aggregation code that was disabled in the Honk-rollup work. Adds a hack to the tube circuit that adds a default aggregation object, which will be fixed in a followup PR (probably #7582).
AztecBot pushed a commit that referenced this issue Jul 26, 2024
@lucasxia01 @AztecBot
feat: adding aggregation to honk and rollup (#7466)
873a1ad 
Closes #1044.

Re-enables (most) aggregation code that was disabled in the Honk-rollup work. Adds a hack to the tube circuit that adds a default aggregation object, which will be fixed in a followup PR (probably AztecProtocol/aztec-packages#7582).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucasxia01 lucasxia01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adding aggregation to honk and rollup AztecProtocol/aztec-packages
1 participant
@lucasxia01