Port UltraComposer changes to UltraPlonkComposer and UltraHonkComposer #378
Assignees
Comments
4 tasks
lucasxia01
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this issue
Sep 25, 2023
At some point during the great composer split, a couple of tests that depended on new builder functionality from Zac were not passing. I confirmed that all of the functionality referenced in bberg issue No 378 has been ported to the one and only `UltraCircuitBuilder` and the previously disabled tests now pass. Note: the tests have been reordered a bit which makes the diff a bit funny but they are largely unchanged. I combined two tests into one since they were highly connected and made minor syntactic changes to get them up to date with the rest of the codebase. Closes bberg issue No. [378](AztecProtocol/barretenberg#378) # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With #366 merging soon, we are ready to refactor all of the composers in
plonkin to split out circuit construction functionality. To do this development incrementally, @Rumata888 has createdFooPlonkComposerforFooin{Standard, Turbo, Ultra}, since the composer interface will change.In the meantime, some changes have gone into
UltraComposerto support NounsDAO builders. We need to make sure these changes are reflected in the refactor.The text was updated successfully, but these errors were encountered: