safe_uint subtraction
#669
Assignees
Labels
Comments
codygunton
added
bug
2 tasks
2 tasks
lucasxia01
added a commit
to AztecProtocol/aztec-packages
that referenced
this issue
Sep 29, 2023
Motivated by AztecProtocol/barretenberg#669. This PR updates the safe_uint tests, and adds more documentation to the tests as well as the subtract and operator- class methods. In more detail: - it fixes TestMinusOperatorUnderflowFails (now named TestMinusUnderflowGeneral1) to check for a failing constraint through `EXPECT_FALSE(composer.check_circuit())` instead of executing without checking anything. - it adds new tests to test edge cases and different failure branches where overflow/underflow occur in the operator+, operator*, subtract(), and operator- methods. - it adds detailed comments to the subtract() and operator- functions, and the corresponding tests. - it moves the subtract, operator-, divide, and operator/ implementations from the header file to the source file. --------- Co-authored-by: maramihali <[email protected]>
AztecBot
pushed a commit
that referenced
this issue
Sep 30, 2023
Motivated by #669. This PR updates the safe_uint tests, and adds more documentation to the tests as well as the subtract and operator- class methods. In more detail: - it fixes TestMinusOperatorUnderflowFails (now named TestMinusUnderflowGeneral1) to check for a failing constraint through `EXPECT_FALSE(composer.check_circuit())` instead of executing without checking anything. - it adds new tests to test edge cases and different failure branches where overflow/underflow occur in the operator+, operator*, subtract(), and operator- methods. - it adds detailed comments to the subtract() and operator- functions, and the corresponding tests. - it moves the subtract, operator-, divide, and operator/ implementations from the header file to the source file. --------- Co-authored-by: maramihali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The safe_uint method which is not tested correctly in
SafeUintTest.TestSubtractMethodUnderflowFails.The text was updated successfully, but these errors were encountered: