Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Merge functionality out of ultra_composer #804

Closed
ledwards2225 opened this issue Dec 6, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#4343
Closed

Move Merge functionality out of ultra_composer #804

ledwards2225 opened this issue Dec 6, 2023 · 0 comments · Fixed by AztecProtocol/aztec-packages#4343
Assignees
@ledwards2225

Comments

@ledwards2225
Copy link
Collaborator

ledwards2225 commented Dec 6, 2023 •
edited
Loading

Originally the merge protocol was part of the UltraHonk protocol. It is now a separate protocol and there is no reason for the ultra_composer to be responsible for constructing the merge prover/verifier. Extract the merge protocol from UltraHonk in this sense and any other to make the abstraction cleaner. Probably Goblin should be responsible for constructing merge prover/verifier. Make any other changes necessary to make the encapsulation clean.
@ledwards2225 ledwards2225 mentioned this issue Jan 31, 2024
Merged
@ledwards2225 ledwards2225 self-assigned this Feb 1, 2024
ledwards2225 added a commit to AztecProtocol/aztec-packages that referenced this issue Feb 2, 2024
@ledwards2225
chore: extract merge from UC and simplify (#4343)
54fd794 
Removes `create_merge_prover`/`verifier` from `UltraComposer`. They are
now constructed directly from their respective class constructors. This
PR also simplifies the merge classes and removes the templating on
Flavor which was unnecessary.

closes AztecProtocol/barretenberg#804
AztecBot pushed a commit that referenced this issue Feb 3, 2024
@ledwards2225 @AztecBot
chore: extract merge from UC and simplify (#4343)
932ed93 
Removes `create_merge_prover`/`verifier` from `UltraComposer`. They are
now constructed directly from their respective class constructors. This
PR also simplifies the merge classes and removes the templating on
Flavor which was unnecessary.

closes #804
TomAFrench pushed a commit to AztecProtocol/aztec-packages that referenced this issue Feb 7, 2024
@ledwards2225 @TomAFrench
chore: extract merge from UC and simplify (#4343)
c8ab095 
Removes `create_merge_prover`/`verifier` from `UltraComposer`. They are
now constructed directly from their respective class constructors. This
PR also simplifies the merge classes and removes the templating on
Flavor which was unnecessary.

closes AztecProtocol/barretenberg#804
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@ledwards2225
chore: extract merge from UC and simplify (AztecProtocol#4343)
5300d00 
Removes `create_merge_prover`/`verifier` from `UltraComposer`. They are
now constructed directly from their respective class constructors. This
PR also simplifies the merge classes and removes the templating on
Flavor which was unnecessary.

closes AztecProtocol/barretenberg#804
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ledwards2225 ledwards2225

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: extract merge from UC and simplify AztecProtocol/aztec-packages
1 participant
@ledwards2225