Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name change: GenPermSort --> DeltaRangeConstraint #919

Closed
ledwards2225 opened this issue Mar 19, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#5378
Closed

Name change: GenPermSort --> DeltaRangeConstraint #919

ledwards2225 opened this issue Mar 19, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#5378
Assignees
@ledwards2225

Comments

@ledwards2225
Copy link
Collaborator

The name GenPermSort is misleading. The relation actually is checking that the difference (delta) between wire values is no more than 3. The original name stems from the context in which this relation is used but says nothing about the actual constraint being applied.
@ledwards2225 ledwards2225 self-assigned this Mar 21, 2024
@ledwards2225 ledwards2225 mentioned this issue Mar 21, 2024
Merged
ludamad pushed a commit to AztecProtocol/aztec-packages that referenced this issue Mar 21, 2024
@ledwards2225
chore: Name change: gen perm sort to delta range constraint (#5378)
841855f 
Change the naming convention "gen perm sort" to "delta range
constraint". The name GenPermSort is misleading. The relation actually
is checking that the difference (delta) between wire values is no more
than 3. The original name stems from the context in which this relation
is used but says nothing about the actual constraint being applied.

Closes AztecProtocol/barretenberg#919
AztecBot pushed a commit that referenced this issue Mar 22, 2024
@ledwards2225 @AztecBot
chore: Name change: gen perm sort to delta range constraint (#5378)
fd0490d 
Change the naming convention "gen perm sort" to "delta range
constraint". The name GenPermSort is misleading. The relation actually
is checking that the difference (delta) between wire values is no more
than 3. The original name stems from the context in which this relation
is used but says nothing about the actual constraint being applied.

Closes #919
sklppy88 pushed a commit to AztecProtocol/aztec-packages that referenced this issue Mar 22, 2024
@ledwards2225 @sklppy88
chore: Name change: gen perm sort to delta range constraint (#5378)
5d1a478 
Change the naming convention "gen perm sort" to "delta range
constraint". The name GenPermSort is misleading. The relation actually
is checking that the difference (delta) between wire values is no more
than 3. The original name stems from the context in which this relation
is used but says nothing about the actual constraint being applied.

Closes AztecProtocol/barretenberg#919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ledwards2225 ledwards2225

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Name change: gen perm sort to delta range constraint AztecProtocol/aztec-packages
1 participant
@ledwards2225