Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for variable size keccak, inputs are zeroed after the requested length #632

Open
wants to merge 3 commits into
base: acvm-backend-barretenberg
Choose a base branch
from

Conversation

guipublic
Copy link
Contributor

Description

Solves noir-lang/noir#1934

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • The branch has been merged with/rebased against the head of its merge target.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • [] There are no circuit changes, OR a cryptographer has been assigned for review.
  • New functions, classes, etc. have been documented according to the doxygen comment format. Classes and structs must have @brief describing the intended functionality.
  • If existing code has been modified, such documentation has been added or updated.
  • No superfluous include directives have been added.
  • I have linked to any issue(s) it resolves.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@kevaundray
Copy link
Contributor

Can you PR this to master and then cherry-pick the commit from master onto acvm-backend-barretenberg instead?

@guipublic
Copy link
Contributor Author

guipublic commented Aug 1, 2023

I have created a new PR here: #646
for merging into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants