Kudu + KEDA publishing for Durable Functions on SQL #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
Mar 18, 2021
pragnagopa
reviewed
Mar 18, 2021
pragnagopa
approved these changes
Mar 18, 2021
|
Tagging @sanchitmehta to help merge and cherry-pick commit to internal repo. @sanchitmehta - @cgillum and I do not have permissions to merge. Please take a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for publishing function apps with Durable Functions triggers that are configured with the new SQL backend.
I had to refactor the existing code a bit since Durable scalers are not 1:1 with function triggers, like they are for all other trigger types. Rather, all durable triggers in a single function app are powered by a single scaler.
I also added a unit test to verify the behavior.