Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to the right page #1245

Closed
mirojs opened this issue Feb 7, 2024 · 7 comments · Fixed by #1283
Closed

Jump to the right page #1245

mirojs opened this issue Feb 7, 2024 · 7 comments · Fixed by #1283

Comments

@mirojs
Copy link

mirojs commented Feb 7, 2024

Please provide us with the following information:

Hello,

Following the recent update, upon clicking the PDF file reference link, the file displayed started from the very first file page instead of the referenced one as worked previously. Anyone observing the same thing?

Thanks!

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ x ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Any log messages given by the failure

Expected/desired behavior

OS and Version?

Windows 7, 8 or 10. Linux (which distribution). macOS (Yosemite? El Capitan? Sierra?)
Linux

azd version?

run azd version and copy paste here.

Versions

Mention any other details that might be useful


Thanks! We'll be in touch soon.

@pamelafox
Copy link
Collaborator

Which browser do you see that in? I see it sometimes in Edge, and I reported the issue to the Edge team. I haven't seen it in Chrome.

@mirojs
Copy link
Author

mirojs commented Feb 8, 2024

@pamelafox I mainly use Chrome and it worked before but not until most recently following the update. Testing on Edge told the same story.

@amreales
Copy link

Seeing the same issue. Tested on Edge, Chrome and Safari, reference document opening in page 1 regardless of the anchor

@Adeelku
Copy link

Adeelku commented Feb 16, 2024

The same issue here, I am using Edge

@pamelafox
Copy link
Collaborator

Ah, I see the issue, this was introduced when we added GPT-4-v support. Working on a fix. Sorry for the delay!

@pamelafox
Copy link
Collaborator

Actually this regression was caused by https://github.com/Azure-Samples/azure-search-openai-demo/pull/1160/files#r1460470297

Still working on a fix

@pamelafox
Copy link
Collaborator

Fix is in review. Necessary changes are in one file:
https://github.com/Azure-Samples/azure-search-openai-demo/pull/1283/files#diff-1c152a9cc611df2db331cd06ae6145ca33249071c2e6c4cf1ae02cb0ea7b8970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants